[Bug 227091] Review Request: objectweb-anttask-1.3.2-1jpp - ObjectWeb Ant task

bugzilla at redhat.com bugzilla at redhat.com
Mon Feb 12 19:38:13 UTC 2007 

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: objectweb-anttask-1.3.2-1jpp - ObjectWeb Ant task


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=227091


pcheung at redhat.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|pcheung at redhat.com          |tbento at redhat.com
               Flag|                            |fedora-review-




------- Additional Comments From pcheung at redhat.com  2007-02-12 14:38 EST -------
MUST:
* package is named appropriately
* license field matches the actual license.
* license is open source-compatible.
* specfile name matches %{name}
* verify source and patches (md5sum matches upstream, know what the patches do)
* skim the summary and description for typos, etc.
X correct buildroot
 - should be:
   %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
locations)
* license text included in package and marked with %doc
* keep old changelog entries; use judgement when removing (too old?
useless?)
* packages meets FHS (http://www.pathname.com/fhs/)
* rpmlint on <this package>.srpm gives no output
W: objectweb-anttask non-standard-group Development/Java
W: objectweb-anttask unversioned-explicit-provides owanttask
W: objectweb-anttask rpm-buildroot-usage %prep rm -rf $RPM_BUILD_ROOT
W: objectweb-anttask mixed-use-of-spaces-and-tabs (spaces: line 9, tab: line 37) 
* changelog should be in one of these formats:
* Packager tag should not be used
X Vendor tag should not be used
* use License and not Copyright
* Summary tag should not end in a period
* if possible, replace PreReq with Requires(pre) and/or Requires(post)
X specfile is legible
 - Requires jpackage-utils in post and postun javadoc
 - Get rid of Vendor and Distribution
 - Fix Release tag
 - Fix Source0:
http://download.fr2.forge.objectweb.org/monolog/ow_util_ant_tasks_1.3.2.zip
 - When adding the gcj bits, BuildArch:      noarch should be removed
 
* package successfully compiles and builds on at least x86
* BuildRequires are proper
 - builds in mock will flush out problems here
i don't have mock setup.

* summary should be a short and concise description of the package
* description expands upon summary (don't include installation
instructions)
X make sure lines are <= 80 characters
 line 80 is longer than 80 characters
* specfile written in American English
* make a -doc sub-package if necessary
 - see
  
http://fedoraproject.org/wiki/Packaging/Guidelines#head-9bbfa57478f0460c6160947a6bf795249488182b
* packages including libraries should exclude static libraries if possible
* don't use rpath
* config files should usually be marked with %config(noreplace)
* GUI apps should contain .desktop files
* should the package contain a -devel sub-package?
* use macros appropriately and consistently
 - ie. %{buildroot} and %{optflags} vs. $RPM_BUILD_ROOT and $RPM_OPT_FLAGS
* don't use %makeinstall
* locale data handling correct (find_lang)
 - if translations included, add BR: gettext and use %find_lang %{name} at the
   end of %install
* consider using cp -p to preserve timestamps
* split Requires(pre,post) into two separate lines
* package should probably not be relocatable
* package contains code
 - see http://fedoraproject.org/wiki/Packaging/Guidelines#CodeVsContent
 - in general, there should be no offensive content
* package should own all directories and files
* there should be no %files duplicates
* file permissions should be okay; %defattrs should be present
* %clean should be present
* %doc files should not affect runtime
* if it is a web apps, it should be in /usr/share/%{name} and *not* /var/www
* verify the final provides and requires of the binary RPMs
[pcheung at tonka jpp]$ rpm -qpl --provides
~/topdir/RPMS/noarch/tagsoup-1.0.1-1jpp.noarch.rpm
tagsoup = 0:1.0.1-1jpp
/usr/share/doc/tagsoup-1.0.1
/usr/share/doc/tagsoup-1.0.1/CHANGES
/usr/share/doc/tagsoup-1.0.1/README
/usr/share/java/tagsoup-1.0.1.jar
/usr/share/java/tagsoup.jar
[pcheung at tonka jpp]$ rpm -qpl --requires
~/topdir/RPMS/noarch/tagsoup-1.0.1-1jpp.noarch.rpm
jpackage-utils >= 0:1.6
rpmlib(CompressedFileNames) <= 3.0.4-1
rpmlib(PayloadFilesHavePrefix) <= 4.0-1
/usr/share/doc/tagsoup-1.0.1
/usr/share/doc/tagsoup-1.0.1/CHANGES
/usr/share/doc/tagsoup-1.0.1/README
/usr/share/java/tagsoup-1.0.1.jar
/usr/share/java/tagsoup.jar
[pcheung at tonka jpp]$ rpm -qpl --provides
~/topdir/RPMS/noarch/tagsoup-javadoc-1.0.1-1jpp.noarch.rpm
tagsoup-javadoc = 0:1.0.1-1jpp
/usr/share/javadoc/tagsoup-1.0.1
/usr/share/javadoc/tagsoup-1.0.1/allclasses-frame.html
/usr/share/javadoc/tagsoup-1.0.1/allclasses-noframe.html
/usr/share/javadoc/tagsoup-1.0.1/constant-values.html
/usr/share/javadoc/tagsoup-1.0.1/deprecated-list.html
/usr/share/javadoc/tagsoup-1.0.1/help-doc.html
/usr/share/javadoc/tagsoup-1.0.1/index-all.html
/usr/share/javadoc/tagsoup-1.0.1/index.html
/usr/share/javadoc/tagsoup-1.0.1/org
/usr/share/javadoc/tagsoup-1.0.1/org/ccil
/usr/share/javadoc/tagsoup-1.0.1/org/ccil/cowan
/usr/share/javadoc/tagsoup-1.0.1/org/ccil/cowan/tagsoup
/usr/share/javadoc/tagsoup-1.0.1/org/ccil/cowan/tagsoup/AttributesImpl.html
/usr/share/javadoc/tagsoup-1.0.1/org/ccil/cowan/tagsoup/AutoDetector.html
/usr/share/javadoc/tagsoup-1.0.1/org/ccil/cowan/tagsoup/CommandLine.html
/usr/share/javadoc/tagsoup-1.0.1/org/ccil/cowan/tagsoup/Element.html
/usr/share/javadoc/tagsoup-1.0.1/org/ccil/cowan/tagsoup/ElementType.html
/usr/share/javadoc/tagsoup-1.0.1/org/ccil/cowan/tagsoup/PYXScanner.html
/usr/share/javadoc/tagsoup-1.0.1/org/ccil/cowan/tagsoup/PYXWriter.html
/usr/share/javadoc/tagsoup-1.0.1/org/ccil/cowan/tagsoup/Parser.html
/usr/share/javadoc/tagsoup-1.0.1/org/ccil/cowan/tagsoup/ScanHandler.html
/usr/share/javadoc/tagsoup-1.0.1/org/ccil/cowan/tagsoup/Scanner.html
/usr/share/javadoc/tagsoup-1.0.1/org/ccil/cowan/tagsoup/Schema.html
/usr/share/javadoc/tagsoup-1.0.1/org/ccil/cowan/tagsoup/XMLWriter.html
/usr/share/javadoc/tagsoup-1.0.1/org/ccil/cowan/tagsoup/class-use
/usr/share/javadoc/tagsoup-1.0.1/org/ccil/cowan/tagsoup/class-use/AttributesImpl.html
/usr/share/javadoc/tagsoup-1.0.1/org/ccil/cowan/tagsoup/class-use/AutoDetector.html
/usr/share/javadoc/tagsoup-1.0.1/org/ccil/cowan/tagsoup/class-use/CommandLine.html
/usr/share/javadoc/tagsoup-1.0.1/org/ccil/cowan/tagsoup/class-use/Element.html
/usr/share/javadoc/tagsoup-1.0.1/org/ccil/cowan/tagsoup/class-use/ElementType.html
/usr/share/javadoc/tagsoup-1.0.1/org/ccil/cowan/tagsoup/class-use/PYXScanner.html
/usr/share/javadoc/tagsoup-1.0.1/org/ccil/cowan/tagsoup/class-use/PYXWriter.html/usr/share/javadoc/tagsoup-1.0.1/org/ccil/cowan/tagsoup/class-use/Parser.html
/usr/share/javadoc/tagsoup-1.0.1/org/ccil/cowan/tagsoup/class-use/ScanHandler.html
/usr/share/javadoc/tagsoup-1.0.1/org/ccil/cowan/tagsoup/class-use/Scanner.html
/usr/share/javadoc/tagsoup-1.0.1/org/ccil/cowan/tagsoup/class-use/Schema.html
/usr/share/javadoc/tagsoup-1.0.1/org/ccil/cowan/tagsoup/class-use/XMLWriter.html/usr/share/javadoc/tagsoup-1.0.1/org/ccil/cowan/tagsoup/package-frame.html
/usr/share/javadoc/tagsoup-1.0.1/org/ccil/cowan/tagsoup/package-summary.html
/usr/share/javadoc/tagsoup-1.0.1/org/ccil/cowan/tagsoup/package-tree.html
/usr/share/javadoc/tagsoup-1.0.1/org/ccil/cowan/tagsoup/package-use.html
/usr/share/javadoc/tagsoup-1.0.1/overview-tree.html
/usr/share/javadoc/tagsoup-1.0.1/package-list
/usr/share/javadoc/tagsoup-1.0.1/resources
/usr/share/javadoc/tagsoup-1.0.1/resources/inherit.gif
/usr/share/javadoc/tagsoup-1.0.1/stylesheet.css
[pcheung at tonka jpp]$ rpm -qpl --requires
~/topdir/RPMS/noarch/tagsoup-javadoc-1.0.1-1jpp.noarch.rpm
rpmlib(CompressedFileNames) <= 3.0.4-1
rpmlib(PayloadFilesHavePrefix) <= 4.0-1
/usr/share/javadoc/tagsoup-1.0.1
/usr/share/javadoc/tagsoup-1.0.1/allclasses-frame.html
/usr/share/javadoc/tagsoup-1.0.1/allclasses-noframe.html
/usr/share/javadoc/tagsoup-1.0.1/constant-values.html
/usr/share/javadoc/tagsoup-1.0.1/deprecated-list.html
/usr/share/javadoc/tagsoup-1.0.1/help-doc.html
/usr/share/javadoc/tagsoup-1.0.1/index-all.html
/usr/share/javadoc/tagsoup-1.0.1/index.html
/usr/share/javadoc/tagsoup-1.0.1/org
/usr/share/javadoc/tagsoup-1.0.1/org/ccil
/usr/share/javadoc/tagsoup-1.0.1/org/ccil/cowan
/usr/share/javadoc/tagsoup-1.0.1/org/ccil/cowan/tagsoup
/usr/share/javadoc/tagsoup-1.0.1/org/ccil/cowan/tagsoup/AttributesImpl.html
/usr/share/javadoc/tagsoup-1.0.1/org/ccil/cowan/tagsoup/AutoDetector.html
/usr/share/javadoc/tagsoup-1.0.1/org/ccil/cowan/tagsoup/CommandLine.html
/usr/share/javadoc/tagsoup-1.0.1/org/ccil/cowan/tagsoup/Element.html
/usr/share/javadoc/tagsoup-1.0.1/org/ccil/cowan/tagsoup/ElementType.html
/usr/share/javadoc/tagsoup-1.0.1/org/ccil/cowan/tagsoup/PYXScanner.html
/usr/share/javadoc/tagsoup-1.0.1/org/ccil/cowan/tagsoup/PYXWriter.html
/usr/share/javadoc/tagsoup-1.0.1/org/ccil/cowan/tagsoup/Parser.html
/usr/share/javadoc/tagsoup-1.0.1/org/ccil/cowan/tagsoup/ScanHandler.html
/usr/share/javadoc/tagsoup-1.0.1/org/ccil/cowan/tagsoup/Scanner.html
/usr/share/javadoc/tagsoup-1.0.1/org/ccil/cowan/tagsoup/Schema.html
/usr/share/javadoc/tagsoup-1.0.1/org/ccil/cowan/tagsoup/XMLWriter.html
/usr/share/javadoc/tagsoup-1.0.1/org/ccil/cowan/tagsoup/class-use
/usr/share/javadoc/tagsoup-1.0.1/org/ccil/cowan/tagsoup/class-use/AttributesImpl.html
/usr/share/javadoc/tagsoup-1.0.1/org/ccil/cowan/tagsoup/class-use/AutoDetector.html
/usr/share/javadoc/tagsoup-1.0.1/org/ccil/cowan/tagsoup/class-use/CommandLine.html
/usr/share/javadoc/tagsoup-1.0.1/org/ccil/cowan/tagsoup/class-use/Element.html
/usr/share/javadoc/tagsoup-1.0.1/org/ccil/cowan/tagsoup/class-use/ElementType.html
/usr/share/javadoc/tagsoup-1.0.1/org/ccil/cowan/tagsoup/class-use/PYXScanner.html
/usr/share/javadoc/tagsoup-1.0.1/org/ccil/cowan/tagsoup/class-use/PYXWriter.html/usr/share/javadoc/tagsoup-1.0.1/org/ccil/cowan/tagsoup/class-use/Parser.html
/usr/share/javadoc/tagsoup-1.0.1/org/ccil/cowan/tagsoup/class-use/ScanHandler.html
/usr/share/javadoc/tagsoup-1.0.1/org/ccil/cowan/tagsoup/class-use/Scanner.html
/usr/share/javadoc/tagsoup-1.0.1/org/ccil/cowan/tagsoup/class-use/Schema.html
/usr/share/javadoc/tagsoup-1.0.1/org/ccil/cowan/tagsoup/class-use/XMLWriter.html/usr/share/javadoc/tagsoup-1.0.1/org/ccil/cowan/tagsoup/package-frame.html
/usr/share/javadoc/tagsoup-1.0.1/org/ccil/cowan/tagsoup/package-summary.html
/usr/share/javadoc/tagsoup-1.0.1/org/ccil/cowan/tagsoup/package-tree.html
/usr/share/javadoc/tagsoup-1.0.1/org/ccil/cowan/tagsoup/package-use.html
/usr/share/javadoc/tagsoup-1.0.1/overview-tree.html
/usr/share/javadoc/tagsoup-1.0.1/package-list
/usr/share/javadoc/tagsoup-1.0.1/resources
/usr/share/javadoc/tagsoup-1.0.1/resources/inherit.gif
/usr/share/javadoc/tagsoup-1.0.1/stylesheet.css
 
* run rpmlint on the binary RPMs
W: objectweb-anttask non-standard-group Development/Java
W: objectweb-anttask incoherent-version-in-changelog 0:1.3.2-2jpp 0:1.3.2-1jpp
W: objectweb-anttask no-documentation
W: objectweb-anttask-javadoc non-standard-group Development/Documentation
W: objectweb-anttask-javadoc dangerous-command-in-%post rm
W: objectweb-anttask-javadoc dangerous-command-in-%postun rm

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.

More information about the Fedora-package-review mailing list