[Bug 227063] Review Request: jakarta-commons-cli-1.0-7jpp - Jakarta Commons CLI, a Command Line Interface for Java

bugzilla at redhat.com bugzilla at redhat.com
Mon Feb 12 22:58:53 UTC 2007 

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: jakarta-commons-cli-1.0-7jpp - Jakarta Commons CLI, a Command Line Interface for Java


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=227063


pcheung at redhat.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|pcheung at redhat.com          |dbhole at redhat.com
               Flag|                            |fedora-review-




------- Additional Comments From pcheung at redhat.com  2007-02-12 17:58 EST -------
MUST:
* package is named appropriately
* is it legal for Fedora to distribute this?
* license field matches the actual license.
* license is open source-compatible.
* specfile name matches %{name}
* verify source and patches (md5sum matches upstream, know what the patches do)
* skim the summary and description for typos, etc.
X correct buildroot
 - should be:
   %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
* if %{?dist} is used, it should be in that form (note the ? and %
locations)
* license text included in package and marked with %doc
* keep old changelog entries; use judgement when removing (too old?
useless?)
* packages meets FHS (http://www.pathname.com/fhs/)
* rpmlint on <this package>.srpm gives no output
 - OK: W: jakarta-commons-cli non-standard-group Development/Libraries/Java
* changelog should be in one of these formats:
* Packager tag should not be used
X Vendor tag should not be used
* use License and not Copyright
* Summary tag should not end in a period
* if possible, replace PreReq with Requires(pre) and/or Requires(post)
X specfile is legible
 - add %define _with_gcj_support 1
 - remove Vendor and Distribution tag
 - fix release tag: 8jpp.1%{?dist}
 - Requires jpackage-utils in post, postun until javadoc is fixed, after that it
can be just a Require
* package successfully compiles and builds on at least x86
* BuildRequires are proper
* summary should be a short and concise description of the package
* description expands upon summary (don't include installation
instructions)
X make sure lines are <= 80 characters
line 109, 110 are longer than 80 characters
* specfile written in American English
* make a -doc sub-package if necessary
* packages including libraries should exclude static libraries if possible
* don't use rpath
* config files should usually be marked with %config(noreplace)
* GUI apps should contain .desktop files
* should the package contain a -devel sub-package?
* use macros appropriately and consistently
* don't use %makeinstall
* locale data handling correct (find_lang)
* consider using cp -p to preserve timestamps
* split Requires(pre,post) into two separate lines
* package should probably not be relocatable
* package contains code
* package should own all directories and files
* there should be no %files duplicates
* file permissions should be okay; %defattrs should be present
* %clean should be present
* %doc files should not affect runtime
* if it is a web apps, it should be in /usr/share/%{name} and *not* /var/www
* verify the final provides and requires of the binary RPMs
[pcheung at topcat downloads]$ rpm -qpl --provides
/home/pcheung/topdir/RPMS/noarch/jakarta-commons-cli-1.0-8jpp.noarch.rpm
jakarta-commons-cli = 0:1.0-8jpp
/usr/share/doc/jakarta-commons-cli-1.0
/usr/share/doc/jakarta-commons-cli-1.0/LICENSE.txt
/usr/share/doc/jakarta-commons-cli-1.0/README.txt
/usr/share/java/commons-cli-1.0.jar
/usr/share/java/commons-cli.jar
/usr/share/java/jakarta-commons-cli-1.0.jar
/usr/share/java/jakarta-commons-cli.jar
[pcheung at topcat downloads]$ rpm -qpl --requires
/home/pcheung/topdir/RPMS/noarch/jakarta-commons-cli-1.0-8jpp.noarch.rpm
jakarta-commons-lang
jakarta-commons-logging
rpmlib(CompressedFileNames) <= 3.0.4-1
rpmlib(PayloadFilesHavePrefix) <= 4.0-1
/usr/share/doc/jakarta-commons-cli-1.0
/usr/share/doc/jakarta-commons-cli-1.0/LICENSE.txt
/usr/share/doc/jakarta-commons-cli-1.0/README.txt
/usr/share/java/commons-cli-1.0.jar
/usr/share/java/commons-cli.jar
/usr/share/java/jakarta-commons-cli-1.0.jar
/usr/share/java/jakarta-commons-cli.jar
[pcheung at topcat downloads]$ rpm -qpl --provides
/home/pcheung/topdir/RPMS/noarch/jakarta-commons-cli-javadoc-1.0-8jpp.noarch.rpm
jakarta-commons-cli-javadoc = 0:1.0-8jpp
/usr/share/javadoc/jakarta-commons-cli-1.0
/usr/share/javadoc/jakarta-commons-cli-1.0/allclasses-frame.html
/usr/share/javadoc/jakarta-commons-cli-1.0/allclasses-noframe.html
/usr/share/javadoc/jakarta-commons-cli-1.0/constant-values.html
/usr/share/javadoc/jakarta-commons-cli-1.0/deprecated-list.html
/usr/share/javadoc/jakarta-commons-cli-1.0/help-doc.html
/usr/share/javadoc/jakarta-commons-cli-1.0/index-all.html
/usr/share/javadoc/jakarta-commons-cli-1.0/index.html
/usr/share/javadoc/jakarta-commons-cli-1.0/org
/usr/share/javadoc/jakarta-commons-cli-1.0/org/apache
/usr/share/javadoc/jakarta-commons-cli-1.0/org/apache/commons
/usr/share/javadoc/jakarta-commons-cli-1.0/org/apache/commons/cli
/usr/share/javadoc/jakarta-commons-cli-1.0/org/apache/commons/cli/AlreadySelectedException.html
/usr/share/javadoc/jakarta-commons-cli-1.0/org/apache/commons/cli/BasicParser.html
/usr/share/javadoc/jakarta-commons-cli-1.0/org/apache/commons/cli/CommandLine.html
/usr/share/javadoc/jakarta-commons-cli-1.0/org/apache/commons/cli/CommandLineParser.html
/usr/share/javadoc/jakarta-commons-cli-1.0/org/apache/commons/cli/GnuParser.html/usr/share/javadoc/jakarta-commons-cli-1.0/org/apache/commons/cli/HelpFormatter.StringBufferComparator.html
/usr/share/javadoc/jakarta-commons-cli-1.0/org/apache/commons/cli/HelpFormatter.html
/usr/share/javadoc/jakarta-commons-cli-1.0/org/apache/commons/cli/MissingArgumentException.html
/usr/share/javadoc/jakarta-commons-cli-1.0/org/apache/commons/cli/MissingOptionException.html
/usr/share/javadoc/jakarta-commons-cli-1.0/org/apache/commons/cli/Option.html
/usr/share/javadoc/jakarta-commons-cli-1.0/org/apache/commons/cli/OptionBuilder.html
/usr/share/javadoc/jakarta-commons-cli-1.0/org/apache/commons/cli/OptionGroup.html
/usr/share/javadoc/jakarta-commons-cli-1.0/org/apache/commons/cli/Options.html
/usr/share/javadoc/jakarta-commons-cli-1.0/org/apache/commons/cli/ParseException.html
/usr/share/javadoc/jakarta-commons-cli-1.0/org/apache/commons/cli/Parser.html
/usr/share/javadoc/jakarta-commons-cli-1.0/org/apache/commons/cli/PatternOptionBuilder.html
/usr/share/javadoc/jakarta-commons-cli-1.0/org/apache/commons/cli/PosixParser.html
/usr/share/javadoc/jakarta-commons-cli-1.0/org/apache/commons/cli/TypeHandler.html
/usr/share/javadoc/jakarta-commons-cli-1.0/org/apache/commons/cli/UnrecognizedOptionException.html
/usr/share/javadoc/jakarta-commons-cli-1.0/org/apache/commons/cli/class-use
/usr/share/javadoc/jakarta-commons-cli-1.0/org/apache/commons/cli/class-use/AlreadySelectedException.html
/usr/share/javadoc/jakarta-commons-cli-1.0/org/apache/commons/cli/class-use/BasicParser.html
/usr/share/javadoc/jakarta-commons-cli-1.0/org/apache/commons/cli/class-use/CommandLine.html
/usr/share/javadoc/jakarta-commons-cli-1.0/org/apache/commons/cli/class-use/CommandLineParser.html
/usr/share/javadoc/jakarta-commons-cli-1.0/org/apache/commons/cli/class-use/GnuParser.html
/usr/share/javadoc/jakarta-commons-cli-1.0/org/apache/commons/cli/class-use/HelpFormatter.StringBufferComparator.html
/usr/share/javadoc/jakarta-commons-cli-1.0/org/apache/commons/cli/class-use/HelpFormatter.html
/usr/share/javadoc/jakarta-commons-cli-1.0/org/apache/commons/cli/class-use/MissingArgumentException.html
/usr/share/javadoc/jakarta-commons-cli-1.0/org/apache/commons/cli/class-use/MissingOptionException.html
/usr/share/javadoc/jakarta-commons-cli-1.0/org/apache/commons/cli/class-use/Option.html
/usr/share/javadoc/jakarta-commons-cli-1.0/org/apache/commons/cli/class-use/OptionBuilder.html
/usr/share/javadoc/jakarta-commons-cli-1.0/org/apache/commons/cli/class-use/OptionGroup.html
/usr/share/javadoc/jakarta-commons-cli-1.0/org/apache/commons/cli/class-use/Options.html
/usr/share/javadoc/jakarta-commons-cli-1.0/org/apache/commons/cli/class-use/ParseException.html
/usr/share/javadoc/jakarta-commons-cli-1.0/org/apache/commons/cli/class-use/Parser.html
/usr/share/javadoc/jakarta-commons-cli-1.0/org/apache/commons/cli/class-use/PatternOptionBuilder.html
/usr/share/javadoc/jakarta-commons-cli-1.0/org/apache/commons/cli/class-use/PosixParser.html
/usr/share/javadoc/jakarta-commons-cli-1.0/org/apache/commons/cli/class-use/TypeHandler.html
/usr/share/javadoc/jakarta-commons-cli-1.0/org/apache/commons/cli/class-use/UnrecognizedOptionException.html
/usr/share/javadoc/jakarta-commons-cli-1.0/org/apache/commons/cli/package-frame.html
/usr/share/javadoc/jakarta-commons-cli-1.0/org/apache/commons/cli/package-summary.html
/usr/share/javadoc/jakarta-commons-cli-1.0/org/apache/commons/cli/package-tree.html
/usr/share/javadoc/jakarta-commons-cli-1.0/org/apache/commons/cli/package-use.html
/usr/share/javadoc/jakarta-commons-cli-1.0/overview-tree.html
/usr/share/javadoc/jakarta-commons-cli-1.0/package-list
/usr/share/javadoc/jakarta-commons-cli-1.0/packages.html
/usr/share/javadoc/jakarta-commons-cli-1.0/resources
/usr/share/javadoc/jakarta-commons-cli-1.0/resources/inherit.gif
/usr/share/javadoc/jakarta-commons-cli-1.0/serialized-form.html
/usr/share/javadoc/jakarta-commons-cli-1.0/stylesheet.css
[pcheung at topcat downloads]$ rpm -qpl --requires
/home/pcheung/topdir/RPMS/noarch/jakarta-commons-cli-javadoc-1.0-8jpp.noarch.rpm
/bin/ln
/bin/rm
/bin/rm
/bin/sh
/bin/sh
rpmlib(CompressedFileNames) <= 3.0.4-1
rpmlib(PayloadFilesHavePrefix) <= 4.0-1
/usr/share/javadoc/jakarta-commons-cli-1.0
/usr/share/javadoc/jakarta-commons-cli-1.0/allclasses-frame.html
/usr/share/javadoc/jakarta-commons-cli-1.0/allclasses-noframe.html
/usr/share/javadoc/jakarta-commons-cli-1.0/constant-values.html
/usr/share/javadoc/jakarta-commons-cli-1.0/deprecated-list.html
/usr/share/javadoc/jakarta-commons-cli-1.0/help-doc.html
/usr/share/javadoc/jakarta-commons-cli-1.0/index-all.html
/usr/share/javadoc/jakarta-commons-cli-1.0/index.html
/usr/share/javadoc/jakarta-commons-cli-1.0/org
/usr/share/javadoc/jakarta-commons-cli-1.0/org/apache
/usr/share/javadoc/jakarta-commons-cli-1.0/org/apache/commons
/usr/share/javadoc/jakarta-commons-cli-1.0/org/apache/commons/cli
/usr/share/javadoc/jakarta-commons-cli-1.0/org/apache/commons/cli/AlreadySelectedException.html
/usr/share/javadoc/jakarta-commons-cli-1.0/org/apache/commons/cli/BasicParser.html
/usr/share/javadoc/jakarta-commons-cli-1.0/org/apache/commons/cli/CommandLine.html
/usr/share/javadoc/jakarta-commons-cli-1.0/org/apache/commons/cli/CommandLineParser.html
/usr/share/javadoc/jakarta-commons-cli-1.0/org/apache/commons/cli/GnuParser.html/usr/share/javadoc/jakarta-commons-cli-1.0/org/apache/commons/cli/HelpFormatter.StringBufferComparator.html
/usr/share/javadoc/jakarta-commons-cli-1.0/org/apache/commons/cli/HelpFormatter.html
/usr/share/javadoc/jakarta-commons-cli-1.0/org/apache/commons/cli/MissingArgumentException.html
/usr/share/javadoc/jakarta-commons-cli-1.0/org/apache/commons/cli/MissingOptionException.html
/usr/share/javadoc/jakarta-commons-cli-1.0/org/apache/commons/cli/Option.html
/usr/share/javadoc/jakarta-commons-cli-1.0/org/apache/commons/cli/OptionBuilder.html
/usr/share/javadoc/jakarta-commons-cli-1.0/org/apache/commons/cli/OptionGroup.html
/usr/share/javadoc/jakarta-commons-cli-1.0/org/apache/commons/cli/Options.html
/usr/share/javadoc/jakarta-commons-cli-1.0/org/apache/commons/cli/ParseException.html
/usr/share/javadoc/jakarta-commons-cli-1.0/org/apache/commons/cli/Parser.html
/usr/share/javadoc/jakarta-commons-cli-1.0/org/apache/commons/cli/PatternOptionBuilder.html
/usr/share/javadoc/jakarta-commons-cli-1.0/org/apache/commons/cli/PosixParser.html
/usr/share/javadoc/jakarta-commons-cli-1.0/org/apache/commons/cli/TypeHandler.html
/usr/share/javadoc/jakarta-commons-cli-1.0/org/apache/commons/cli/UnrecognizedOptionException.html
/usr/share/javadoc/jakarta-commons-cli-1.0/org/apache/commons/cli/class-use
/usr/share/javadoc/jakarta-commons-cli-1.0/org/apache/commons/cli/class-use/AlreadySelectedException.html
/usr/share/javadoc/jakarta-commons-cli-1.0/org/apache/commons/cli/class-use/BasicParser.html
/usr/share/javadoc/jakarta-commons-cli-1.0/org/apache/commons/cli/class-use/CommandLine.html
/usr/share/javadoc/jakarta-commons-cli-1.0/org/apache/commons/cli/class-use/CommandLineParser.html
/usr/share/javadoc/jakarta-commons-cli-1.0/org/apache/commons/cli/class-use/GnuParser.html
/usr/share/javadoc/jakarta-commons-cli-1.0/org/apache/commons/cli/class-use/HelpFormatter.StringBufferComparator.html
/usr/share/javadoc/jakarta-commons-cli-1.0/org/apache/commons/cli/class-use/HelpFormatter.html
/usr/share/javadoc/jakarta-commons-cli-1.0/org/apache/commons/cli/class-use/MissingArgumentException.html
/usr/share/javadoc/jakarta-commons-cli-1.0/org/apache/commons/cli/class-use/MissingOptionException.html
/usr/share/javadoc/jakarta-commons-cli-1.0/org/apache/commons/cli/class-use/Option.html
/usr/share/javadoc/jakarta-commons-cli-1.0/org/apache/commons/cli/class-use/OptionBuilder.html
/usr/share/javadoc/jakarta-commons-cli-1.0/org/apache/commons/cli/class-use/OptionGroup.html
/usr/share/javadoc/jakarta-commons-cli-1.0/org/apache/commons/cli/class-use/Options.html
/usr/share/javadoc/jakarta-commons-cli-1.0/org/apache/commons/cli/class-use/ParseException.html
/usr/share/javadoc/jakarta-commons-cli-1.0/org/apache/commons/cli/class-use/Parser.html
/usr/share/javadoc/jakarta-commons-cli-1.0/org/apache/commons/cli/class-use/PatternOptionBuilder.html
/usr/share/javadoc/jakarta-commons-cli-1.0/org/apache/commons/cli/class-use/PosixParser.html
/usr/share/javadoc/jakarta-commons-cli-1.0/org/apache/commons/cli/class-use/TypeHandler.html
/usr/share/javadoc/jakarta-commons-cli-1.0/org/apache/commons/cli/class-use/UnrecognizedOptionException.html
/usr/share/javadoc/jakarta-commons-cli-1.0/org/apache/commons/cli/package-frame.html
/usr/share/javadoc/jakarta-commons-cli-1.0/org/apache/commons/cli/package-summary.html
/usr/share/javadoc/jakarta-commons-cli-1.0/org/apache/commons/cli/package-tree.html
/usr/share/javadoc/jakarta-commons-cli-1.0/org/apache/commons/cli/package-use.html
/usr/share/javadoc/jakarta-commons-cli-1.0/overview-tree.html
/usr/share/javadoc/jakarta-commons-cli-1.0/package-list
/usr/share/javadoc/jakarta-commons-cli-1.0/packages.html
/usr/share/javadoc/jakarta-commons-cli-1.0/resources
/usr/share/javadoc/jakarta-commons-cli-1.0/resources/inherit.gif
/usr/share/javadoc/jakarta-commons-cli-1.0/serialized-form.html
/usr/share/javadoc/jakarta-commons-cli-1.0/stylesheet.css
 
* run rpmlint on the binary RPMs
W: jakarta-commons-cli non-standard-group Development/Libraries/Java
W: jakarta-commons-cli-javadoc non-standard-group Development/Documentation
W: jakarta-commons-cli-javadoc dangerous-command-in-%post rm
W: jakarta-commons-cli-javadoc dangerous-command-in-%postun rm
 
SHOULD:
* package should include license text in the package and mark it with %doc
* package should build on i386
* package should build in mock


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.

More information about the Fedora-package-review mailing list