[Bug 227117] Review Request: tagsoup-1.0.1-1jpp - A SAX-compliant parser written in Java that parses HTML as it is found in the wild: nasty and brutish

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: tagsoup-1.0.1-1jpp - A SAX-compliant parser written in Java that parses HTML as it is found in the wild: nasty and brutish


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=227117


vivekl at redhat.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|vivekl at redhat.com           |pcheung at redhat.com
               Flag|fedora-review-              |fedora-review?




------- Additional Comments From vivekl at redhat.com  2007-02-12 21:12 EST -------
(In reply to comment #1)
>       X MUST: rpmlint must be run on every package. The output should be
>       posted
> in the review.
> rpmlint output:
> E: tagsoup summary-too-long A SAX-compliant parser written in Java that
> parses
> HTML as it is found in the wild: nasty and brutish
  Fixed.
> W: tagsoup non-standard-group Text Processing/Markup/XML
  Ignoring
> W: tagsoup mixed-use-of-spaces-and-tabs (spaces: line 9, tab: line 41)
  Fixed.
> Error while reading /home/pcheung/tagsoup: error reading package header
? Dont see this anymore
>       X MUST: The package must meet the Packaging Guidelines.
>  
> Release: should be 1jpp.1%{?dist}
Fixed.

> BuildRoot: should be
> %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
Done
>       X MUST: If (and only if) the source package includes the text of the
> license(s) in its own file, then that file, containing the text of the
> license(s) for the package must be included in %doc.
>  
> LICENCE file missing in %doc
Fixed.

>  
>       X MUST: The spec file must be written in American English.
> not needed:
> Vendor:         JPackage Project
> Distribution:   JPackage
Fixed
> When adding gcj bits, remove BuildArch:      noarch
?

> The license is a  disjunction of the Academic Free License,
> version 3.0, and the GNU General Public License, version 2.0
The GPL (like) item in the License field is good enough IMO

> lines are > 80 characters: line 37, 76
Fixed but some lines are forced to overflow (especially after GCJ support)
> URL doesn't exist: http://mercury.ccil.org/~cowan/XML/tagsoup/
Changed to http://home.ccil.org/~cowan/XML/tagsoup/

Also fixed the javadoc handling following the suggestion here:
https://zarb.org/pipermail/jpackage-discuss/2007-February/011119.html

NOTE: SRPM/RPMS available at:
http://tequila-sunrise.ath.cx/rpmreviews/F7/tagsoup/tagsoup-1.0.1-1jpp.1.fc7.src.rpm




-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.