[Bug 228425] Review Request: gtkpod - Graphical song management program for Apple's iPod

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: gtkpod - Graphical song management program for Apple's iPod
Alias: gtkpod-review

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=228425





------- Additional Comments From tmz at pobox.com  2007-02-13 00:45 EST -------
Hi Xavier,

> * gtk2-devel for BuildRequires is redundant. libglade2-devel
>   requires gtk2-devel.

Fixed.

> * You should comment why you apply a patch.

Okay.  Done.  In this case the patch is from upstream and is required to build
against libgpod-0.4.2.

> * Desktop file:
>   personnaly, i don't like to use cat << eof to create desktop file.
>   I think it's better to add desktop file as Source file.

Done.

>   "X-livna" must be removed from categorie.

Egad, that's an embarrassing copy and paste error on my part (I was working on
an update to gtkpod for livna).

Fixed.

> * Please use install -Dm 644 instead of %{__install} -D -m 0644
> * Same thing for %{__mkdir_p}.

Done.

> * in desktop-file-intall entry:
>   use of "--vendor livna" is deprecated and must be removed, 
>   just use --vendor ""

Shouldn't it be fedora instead?  The guidlines say "If upstream uses
<vendor_id>, leave it intact, otherwise use fedora as <vendor_id>."

I used fedora in the latest spec.

>   Also add --mode 0644

Done.  (Is that really needed?  It's not in the guidelines and the file in a
built package are the proper mode.  I'm curious now. :)

> you should make use of GTK+ icon cache
> See :
>
http://fedoraproject.org/wiki/Packaging/ScriptletSnippets?action=show&redirect=ScriptletSnippets#head-7103f6c38d1b5735e8477bdd569ad73ea2c49bda
> 
> %post
> touch --no-create %{_datadir}/icons/hicolor || :
> %{_bindir}/gtk-update-icon-cache --quiet %{_datadir}/icons/hicolor || :
> 
> %postun
> touch --no-create %{_datadir}/icons/hicolor || :
> %{_bindir}/gtk-update-icon-cache --quiet %{_datadir}/icons/hicolor ||

The icon isn't installed into %{_datadir}/icons/hicolor but into
%{_datadir}/pixmaps.  I didn't think that was relevant then.  Or are you
suggesting that I install the icon under %{_datadir}/icons/hicolor?

> The file NEWS is useless, you can drop it as its contents refers to ChangeLog

Done.

> Rpmlint isn't silent from srpm file:
>           -- E: gtkpod unknown-key PGP#beaf0ce3 --
> 
> SOULDN'T: Packages must not be sign with your own key

Sorry, I'm a bit of a crypto geek and I sign things a lot.

Here are the updated files:

Spec URL: http://pobox.com/~tmz/fedora/gtkpod/gtkpod.spec
SRPM URL: http://pobox.com/~tmz/fedora/gtkpod/gtkpod-0.99.8-2.fc6.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.