[Bug 222039] Review Request: ogdi - Open Geographic Datastore Interface

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: ogdi - Open Geographic Datastore Interface


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=222039





------- Additional Comments From cbalint at redhat.com  2007-02-13 08:10 EST -------
(In reply to comment #33)
> * in %files, there is no need of * for odbc, so
> %{_libdir}/%{name}/liblodbc.so*
> should be replaced with
> %{_libdir}/%{name}/liblodbc.so

fixed.

> 
> * no need to duplicate the documentation in all the subpackages.
> LICENSE NEWS ChangeLog README
> could be only in the main package.

fixed, leaved only README in the odbc/tcl package (at last need something).

 
> * HOWTO-RELEASE isn't usefull in the fedora package
get rid
> * The following is useless and should be removed:
> %post tcl -p /sbin/ldconfig
> %postun tcl -p /sbin/ldconfig

oh yes. Those are now private libs.

> * there is a license issue for vpflib. In LICENSE, there is:
> 
> vpflib/*:
> 
> No license mentioned, public domain?
> 
> 
> 
> However some files in vpflib have an author, which means a copyright
> owner. Without license they are under the default license which is
> a restrictive license (no redistribution, no modification).
> 
> * there is also a license issue for ogdi/c-api/gmath.c:
> 
> ogdi/c-api/gmath.c is:
>    Derived from Numerical methods in C

> 
> Looking at this book it seems that the codes are under a proprietary
> license.
> * there is a license issue for vpflib. In LICENSE, there is:
>vpflib/*:
>No license mentioned, public domain?

>However some files in vpflib have an author, which means a copyright
>owner. Without license they are under the default license which is
>a restrictive license (no redistribution, no modification).

I try contact tham and sort this out.

>* there is also a license issue for ogdi/c-api/gmath.c:
>ogdi/c-api/gmath.c is:
>   Derived from Numerical methods in C

Is this insuficcient (from .c header):

Looking at this book it seems that the codes are under a proprietary
******************************************************************************
 * Derived from Numerical methods in C.
 *
 * Copyright (C) 1995 Logiciels et Applications Scientifiques (L.A.S.) Inc
 * Permission to use, copy, modify and distribute this software and
 * its documentation for any purpose and without fee is hereby granted,
 * provided that the above copyright notice appear in all copies, that
 * both the copyright notice and this permission notice appear in
 * supporting documentation, and that the name of L.A.S. Inc not be used
 * in advertising or publicity pertaining to distribution of the software
 * without specific, written prior permission. L.A.S. Inc. makes no
 * representations about the suitability of this software for any purpose.
 * It is provided "as is" without express or implied warranty.
 
******************************************************************************

> 
> Suggestions:
> 
> * The timestamps of source file aren't the same that those 
>   spectool -g gets (but otherwise source match upstream)
> * use
> %defattr(-,root,root,-)
> instead of
> %defattr(-,root,root)

fixed. 

-2 updated.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.