[Bug 228479] Review Request: hunspell-hr - Croatian hunspell dictionaries
bugzilla at redhat.com
bugzilla at redhat.com
Tue Feb 13 23:17:05 UTC 2007
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: hunspell-hr - Croatian hunspell dictionaries
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=228479
wolfy at nobugconsulting.ro changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |ASSIGNED
AssignedTo|nobody at fedoraproject.org |wolfy at nobugconsulting.ro
OtherBugsDependingO|163776 |163779
nThis| |
Flag| |fedora-review+
------- Additional Comments From wolfy at nobugconsulting.ro 2007-02-13 18:17 EST -------
GOOD
- package meets naming guidelines
- package meets packaging guidelines
- spec file legible, in am. english
- source matches upstream , sha1sum
60fa001543ab9e67f20fcc68c358c62f81e006ac hr_HR.zip
- the package builds in mock for devel/x86_64, generates a noarch (which is
consistent with the fact that basically it includes only 3 text files)
- the license LGPL stated in the tag is the same as the web site says
- there are only 2 files (word lists) + a short doc with instructions and
license clearance, so no .la, .pc, static files
- no missing BR
- no locales
- not relocatable
- owns all files/directories that it creates, does not take ownership of other
files/dirs
- no duplicate files
- permissions ok
- %clean ok
- macro use consistent
- rpmlint output is silent
- code, not content
- no need for -docs as the only doc is just a 2 liner specifying that the
license is dual, LGPL/SISSL
- nothing in %doc affects runtime
- no need for .desktop file
APPROVED
SHOULD: please ask upstream to include the actual license file in the archive
--
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.
More information about the Fedora-package-review
mailing list