Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: hunspell-ms - Malay hunspell dictionaries
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=228488
wolfy at nobugconsulting.ro changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |ASSIGNED
AssignedTo|nobody at fedoraproject.org |wolfy at nobugconsulting.ro
OtherBugsDependingO|163776 |163779
nThis| |
Flag| |fedora-review+
------- Additional Comments From wolfy at nobugconsulting.ro 2007-02-13 19:09 EST -------
GOOD
- package meets naming guidelines
- package meets packaging guidelines
- spec file legible, in am. english
- source matches upstream , sha1sum
12c033608d031ded21219757ac26f3b5bc0d37d7 ms_MY.zip
- the package builds in mock for devel/x86_64, generates a noarch (which is
consistent with the fact that basically it includes only 3 text files)
- the license ( GFDL ) stated in the tag is the same as the web site and an
included txt file say; it is not included in the package because upstream did
not include it either
- there are only 2 files (word lists) + a short doc with instructions and
license clearance, so no need for -doc and no .la, .pc, static files
- no missing BR
- no locales
- not relocatable
- owns all files/directories that it creates, does not take ownership of other
files/dirs
- no duplicate files
- permissions ok
- %clean ok
- macro use consistent
- rpmlint output is silent
- code, not content
- nothing in %doc affects runtime
- no need for .desktop file
SHOULD: please ask upstream to include the license in the archive; I think that
it would be a good idea if you could persuade them to hink again about the
license they use, as GFDL seems a bit restrictive and is not very "loved" in
Fedora (and Debian...)
APPROVED
--
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.