[Bug 228501] Review Request: hunspell-th - Thai hunspell dictionaries

bugzilla at redhat.com bugzilla at redhat.com
Wed Feb 14 11:53:36 UTC 2007


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: hunspell-th - Thai hunspell dictionaries


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=228501


wolfy at nobugconsulting.ro changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|nobody at fedoraproject.org    |wolfy at nobugconsulting.ro
OtherBugsDependingO|163776                      |163778
              nThis|                            |
               Flag|                            |fedora-review?




------- Additional Comments From wolfy at nobugconsulting.ro  2007-02-14 06:53 EST -------
Upstream version has been updated, current one is 12-Dec-2006. Therefore the
upstream source and the one included in the src.rpm do not coincide.

GOOD

- package meets naming guidelines
- package meets packaging guidelines 
- spec file legible, in am. english
- the package builds in mock for devel/x86_64, generates a noarch (which is
consistent with the fact that basically it includes only 3 text files)
- the license LGPL stated in the tag is the same as the web site says and is not
 included in the package because upstream does not include it either; it is
however mentioned in a bundled README
- there are only 2 files (word lists) + a short doc with instructions and
license clearance, so no need for -doc and no .la, .pc, static files
- no missing BR
- no locales
- not relocatable
- owns all files/directories that it creates, does not take ownership of other
files/dirs
- no duplicate files
- permissions ok
- %clean ok
- macro use consistent
- rpmlint output is silent
- code, not content
- nothing in %doc affects runtime
- no need for .desktop file 

MUSTFIX
36e94fd62cc246ebb083fbab8ce200b07a2934c2  th_TH.zip (upstream)
d0ec83646ea1d0a4fd1262dec44ac97e59bcfefa  th_TH.zip (bundled in src.rpm)

SHOULD
Please ask upstream to include the license in the archive

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.




More information about the Fedora-package-review mailing list