[Bug 226133] Merge Review: mc

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Merge Review: mc


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=226133





------- Additional Comments From jnovy at redhat.com  2007-02-15 09:00 EST -------
(In reply to comment #5)
> BAD	rpmlint is not silent.
> 
> W: mc conffile-without-noreplace-flag /etc/mc/cedit.menu
> W: mc conffile-without-noreplace-flag /etc/mc/edit.indent.rc
> W: mc conffile-without-noreplace-flag /etc/mc/edit.spell.rc
> W: mc conffile-without-noreplace-flag /etc/mc/extfs/extfs.ini
> W: mc conffile-without-noreplace-flag /etc/mc/extfs/sfs.ini
> W: mc conffile-without-noreplace-flag /etc/mc/mc.charsets
> W: mc conffile-without-noreplace-flag /etc/mc/mc.ext
> W: mc conffile-without-noreplace-flag /etc/mc/mc.lib
> W: mc conffile-without-noreplace-flag /etc/mc/mc.menu
> W: mc conffile-without-noreplace-flag /etc/mc/syntax/Syntax
>     at least mc.ext, mc.menu should be "noreplace", maybe all

Ok all of them are now noreplace except the mc.charsets and mc.lib -> I left
those as config only. It's unlikely that anyone wants to change it.

> W: mc conffile-without-noreplace-flag /etc/profile.d/mc.csh
> W: mc conffile-without-noreplace-flag /etc/profile.d/mc.sh

I removed the config flag from these.

> E: mc script-without-shebang /usr/share/mc/bin/mc-wrapper.sh
> E: mc script-without-shebang /usr/share/mc/bin/mc-wrapper.csh

It's ok, because they are called by mc.sh and mc.csh via source.

> E: mc executable-marked-as-config-file /etc/profile.d/mc.sh
> E: mc executable-sourced-script /etc/profile.d/mc.sh 0755
> E: mc non-executable-script /etc/mc/edit.spell.rc 0644
> E: mc script-without-shebang /usr/share/mc/bin/mc.sh
> E: mc script-without-shebang /usr/share/mc/bin/mc.csh
> 
> E: mc non-standard-uid /usr/libexec/mc/cons.saver vcsa
> E: mc setuid-binary /usr/libexec/mc/cons.saver vcsa 04711
> E: mc non-standard-executable-perm /usr/libexec/mc/cons.saver 04711
> E: mc non-standard-executable-perm /usr/libexec/mc/cons.saver 04711

The above is required to save console contents.



-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.