[Bug 228425] Review Request: gtkpod - Graphical song management program for Apple's iPod

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: gtkpod - Graphical song management program for Apple's iPod
Alias: gtkpod-review

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=228425





------- Additional Comments From mtasaka at ioa.s.u-tokyo.ac.jp  2007-02-16 00:18 EST -------
(In reply to comment #5)
 
> > * You should add timestamp to make install:
> > make install DESTDIR=$RPM_BUILD_ROOT INSTALL="install -p"
> 
> I have never seen that required or recommended before.  Could you tell me why
> you feel it is needed and where it is discussed or recommended?  I use the
> install line straight from the specfile template in rpmdevtools.

Well, first check the "Timestamps" of
http://fedoraproject.org/wiki/Packaging/Guidelines

Keeping timestamps on the files as much as possible makes
it easier to check:
* if the vendor (like you) has modified the original file
* and when the files are created or modified
and
* this may avoid the creation of .rpmsave .rpmnew files
  when it is unnecessary

So keeping timestamps is recommended, especially on documentations,
image files, configuration files, ...

Well, the ways to keep timestamps on the files automatically installed
by "make install" differ according to packages, however,
in general cases "make INSTALL="install -p" install" works.
(there are many cases in that more fixes are needed). 

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.