[Bug 217654] Review Request: TMDA - Tagged Message Delivery Agent
bugzilla at redhat.com
bugzilla at redhat.com
Sat Feb 17 18:37:33 UTC 2007
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: TMDA - Tagged Message Delivery Agent
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=217654
------- Additional Comments From bjohnson at symetrix.com 2007-02-17 13:37 EST -------
(In reply to comment #7)
> - Usually the dependency against main package should be release specific.
> i.e.
Duh, I knew that :-/
> * Cosmetic issue: consistent macro use
> - Well, you use both
> %{_sysconfdir}/rc.d/init.d
> %{_initrddir}
Good catch, I will fix that.
> - Maybe the following documents are useful?
> NEWS (usually this should be included)
I will add this.
> * For -emacs package:
> - Well, I don't think it is useful to split only one file with 27K
> and to create another package with have no dependency essentially.
> And.. tmda.el is installed in main package as a documentation.
>
> IMO simply unifying .el file into main package and having both
> %{_datadir}/emacs and %{_datadir}/emacs/site-lisp directories owned
> also by main package, removing emacs dependency is simpler.
Isn't this contrary to the same argument being used against logrotate scripts now?
The packaging guidelines
(http://fedoraproject.org/wiki/Packaging/Guidelines#head-a5931a7372c4a00065713430984fa5875513e6d4),
one file and directory ownership say:
"The rule of thumb is that your package should own all of the directories it
creates except those owned by packages which your package depends on."
If I create a subpackage, it has two beneficial effects:
1) I don't break the rules and make exceptions for my package.
2) I don't drag in emacs dependencies to the main package.
> And.. tmda.el is installed in main package as a documentation.
And to address this specifically... Yes, it came from documentation, to add
additional functionality as I did with print{cdb,dbm}. We always have the
option to just include it in %docs and not pull it in like I do. What do you
think about that?
--
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.
More information about the Fedora-package-review
mailing list