[Bug 228537] Review Request: perl-IO-Compress-Base - Base package for new perl-IO-Compress modules

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: perl-IO-Compress-Base - Base package for new perl-IO-Compress modules


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=228537


jpo at di.uminho.pt changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
OtherBugsDependingO|188265                      |163779
              nThis|                            |
               Flag|fedora-review?              |fedora-review+




------- Additional Comments From jpo at di.uminho.pt  2007-02-18 16:28 EST -------
APPROVED

MD5SUMS:
98971ee00adfe5c0f2d1e730066ba9c0  perl-IO-Compress-Base-2.003-1.src.rpm

7927ee59cc3c16609397be1d7d32ba01  IO-Compress-Base-2.003.tar.gz
0f5fd8ee458daa4792f509d2dce2ea53  perl-IO-Compress-Base.spec

Sources:
* IO-Compress-Base-2.003.tar.gz: MD5 digest verified against CPAN tarball
(<cpan>/authors/id/P/PM/PMQS/IO-Compress-Base-2.003.tar.gz)

Good:
* Package name follows standard
* URL and Source0 urls are valid
* License verified (README file and main POD page)
* perl(:MODULE_COMPAT_xxx) present
* perl vendor libs present
* File permissions are sane
* No active tickets in
  http://rt.cpan.org/Public/Dist/Display.html?Name=IO-Compress-Base


Notes/Suggestions:

* %files section
  replace
    %{perl_vendorlib}/*
  by
    P%{perl_vendorlib}/File/
    %{perl_vendorlib}/IO/
  and (maybe)
    %{_mandir}/man3/*
  by
    %{_mandir}/man3/*.3pm*

* build requirements
  add the following comments
    #BuildRequires:  perl(Test::Pod)
    #BuildRequires:  perl(Test::NoWarnings)

  Both these modules are available in Extras, but I still
  don't know when the building system will be able to pull
  Extras packages.

* Warning: IO::Compress::Base will be a perl 5.10 core module.


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.