[Bug 228707] Review Request: KoboDeluxe - 3'rd person scrolling 2D shooter

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: KoboDeluxe - 3'rd person scrolling 2D shooter


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=228707





------- Additional Comments From j.w.r.degoede at hhs.nl  2007-02-19 10:58 EST -------
(In reply to comment #2)
> Created an attachment (id=148205)
 --> (https://bugzilla.redhat.com/bugzilla/attachment.cgi?id=148205&action=view) [edit]
> Mock build log of  KoboDeluxe-0.4-0.1.pre10.fc7
> 
> Well, for 0.4-0.1.pre10:
> 
> * BuildRequires
>   - mockbuild fails on FC7 i386. SDL_image-devel seems
>     to be needed for BuildRequires.
> 
Oops, fixed

> * Encodings
>   - Some documentations installed by this package have
>     other Encodings than UTF-8. Please change them to
>     UTF-8.
> ------------------------------------------------------
> README		  ISO-8859-1
> README.jp	  ISO-2022-JP
> README.xkobo.jp   ISO-2022-JP
> ------------------------------------------------------
> 
Strange rpmlint didn't complain about this, fixed.

> * Documentation
>   - README.osx
>     I don't think this is useful.
> 
Agreed, no longer installed

> * Timestamps
>   - This package contains many data files (especially
>     under %{_datadir}/%{_name} ) and keeping
>     timestamps on these files are recommended. 
> 
Fixed

> * Setgid bits
>   - Well, would you just explain why setgid bits is required
>     for the binary?
> 

Because it needs a shared (between users) writable dir to keep its highscore,
normally games like this are either patched to:
1) be sgid games, then first thing in main open the shared highscore-file in rw 
   mode (and keep it open until exit), then fully drop sgid games rights.
2) use a per user highscore file under $HOME instead

Due to the design of the highscore system of KoboDeluxe neither one of these 2
solutions is easy doable, thus we go to the third seldom used solution sgid to a 
unique sgid, as is done also for example with several games in the bsdgames package.


   

> ? Alsa issue
>   - Well I tried to enable alsa support, however it failed
>     because this package is for some old alsa-lib support
>     (around alsa-lib 0.5.9). Well, if it is preferred to
>     make this package have alsa support, would you contact
>     upstream?
> 

This is not really a problem as without any configure switches it uses SDL for
sound, which by default uses also while also allowing for the use of esd, arts
and oss through environment settings.


> * Functionality
>   - Well, I tried this package on both FC5 and FC-devel.
>     On FC-5, there is no problem, however, on FC-devel,
>     it seems that kobodl hangs up completely.
> 
>     Well, as it hangs up after swithing to full screen mode,
>     I don't know how to get a backtrace... Would you know
>     any idea?

Found it (nasty bug) strange enough it doesn't show up on 64 bit machines,
fixed now (see -audio.patch).

New version here:
Spec URL: http://people.atrpms.net/~hdegoede/KoboDeluxe.spec
SRPM URL: http://people.atrpms.net/~hdegoede/KoboDeluxe-0.4-0.2.pre10.fc7.src.rpm



-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.