[Bug 229319] Review Request: dekorator - KDE window decoration engine

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: dekorator - KDE window decoration engine


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=229319





------- Additional Comments From faucamp at csir.co.za  2007-02-20 14:29 EST -------
(In reply to comment #6)
> #001: You should explicitly require kdebase, since this package is useless
> without kwin.
> Requires:      kdebase
> 

Ok, will do.

> #002: other themes ??
...
> 
>     * Bushido-Yellow-theme - shows how masking can be done.
> 

The Bushido-Yellow-theme from the tarball does not do its masking properly (on
my system at least) - it cuts out the central window titlebar-area, making it
impossible to see the window title. I will see if I can edit the masks to make
it work properly, otherwise, I'll remove the references from the help file (the
other themes also demonstrate masking anyway).
The theme is also available here:
http://www.kde-look.org/content/show.php?content=32163
...but this version is not compatible with dekorator 0.3.

As for the "K-style: Infinity" theme: the version packaged with dekorator is
broken, according to its author:
http://www.kde-look.org/content/show.php?content=35590
I think a separate package for this theme (using the updated source) would be
better.

> 
> #003: Below that same page (help), there is a typo "Allways", it should be
> Always. Patch as appropriate and inform upstream.
> 

Will do.

> #004: Is there any reason why you are shipping ugly-theme.tar.gz at
> /usr/share/doc/dekorator-0.3/themes/ ?
> 

Simply because it's, well, ugly ;-), and obviously designed to be a teaching
example, not an _actual_ theme... Should I rather install this by default? Or
maybe put it in a subpackage? I was wondering about the "template" theme as
well, but at least that one's usable and semi-nice to look at.

> #005 I've also noticed that /usr/share/doc/dekorator-0.3/themes/deKhelp.xhtml is
> a duplicate to the "help" page provided by the kcontrol module.

Very similar, yes. I will remove this.

> 
> #006: For the very first time, one select and use dekorator, he/she will be
> frameless. Users will freak out. Can you do the necessary so that a default
> theme might be chosen by default.

I agree, this is *very* irritating. I will look into this; it shouldn't be too
hard. I have a question, though: do you think I should make it so that the "Set
Theme Path" button's actions are automatically performed when the user selects a
theme from the list (and thus remove the button completely)? Or should the
program only select an initial default theme, and leave the "set theme path"
button as it is? Personally I feel the "set theme path" button is an unnecessary
and unintuitive step and should be removed, but someone else's opinion would be
greatly appreciated.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.