[Bug 228295] Review Request: kbilliards - A Fun Billiards Simulator Game

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: kbilliards - A Fun Billiards Simulator Game


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=228295





------- Additional Comments From j.w.r.degoede at hhs.nl  2007-02-22 10:54 EST -------
(In reply to comment #1)
> Well, for 0.8.7b-1:
> 
> * gettext po file
>   - Can't the gettext po files under .po/ directory be used
>     for this program?
>     (One possibility is that with adding gettext as BuildRequires,
>      gettext may try to compile po files automatically, or you
>      have to use msgfmt manually anyway).
> 
Well on my system with gettext installed ./configure says:
"checking if po should be compiled... yes"
And then make (install) doesn't do anything under the po dir :|
So I've added a manual conversion and install of the .po files to the specfile

> * Documentation
>   - What is the following files?
> ---------------------------------------------------
> ./src/NOATUN_AUTHORS
> ---------------------------------------------------
> 

A list of the authors of the noatun KDE media player, further investigations
has learned me that src/soundengine.* contain portions of noatun code, so
I'll add this file to %doc

> * index.docbook
>   Usually KDE applications try to install index.docbook
>   (here ./doc/en/index.docbook) under /usr/share/doc/HTML/.
>   For this packages, can this be ignored?
> 

This is just a template document from the kde app template, nothing usefull
there.

> * Other miscs
>   - What are the files under ./wafadmin directory?

>From the README file:
"2) You can compile kbilliards also with "waf" in three steps:

./waf.py configure

./waf.py build

./waf.py install"


New version with the noatun authors file added and the .po files installed here:
Spec URL: http://people.atrpms.net/~hdegoede/kbilliards.spec
SRPM URL: http://people.atrpms.net/~hdegoede/kbilliards-0.8.7b-2.fc7.src.rpm


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.