[Bug 226316] Merge Review: privoxy

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Merge Review: privoxy


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=226316





------- Additional Comments From paskalis at di.uoa.gr  2007-02-23 10:45 EST -------
Karsten,

Some (rather minor compared to the initial spec) issues/questions before approval:

- Why do you convert the man page from ISO-8859-1 to UTF-8?  AFAIK, ISO-8859-1
is a subset of UTF-8, and any ISO-8859-1 text should also be UTF-8 text. 
Moreover, the manpage is in ASCII, an even smaller subset of UTF-8.  Is there
any reason for this conversion?

- The specfile has really changed a lot since the junkbuster days.  Is it really
necessary to keep the first 27 lines stating copyrights of the program and a
summary of the GPL.  I believe a reference of the GPL in the license field
should be enough to make it clear that the program is GPL.

- Regarding the dynamic or static pcre linking, I am not sure what would be the
best thing to do right now.  Fact is that the included pcre library used for
static linking is very old.  It is actually pcre-3.4 dated August 2000!  Any
fixes during the last 6.5 years are ignored by privoxy if it is compiled using
the very old internal copy.  On the other hand, the vast majority of privoxy
users (most privoxy packages are built with --disable-dynamic-pcre, including
Windows builds) use the static internal version, so more testers.  My proposal
would be to switch to dynamic pcre linking as soon as possible even if it causes
some yet unseen bugs.

Other than those issues, the package is good to go.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.