[Bug 226658] Merge Review: xsane

bugzilla at redhat.com bugzilla at redhat.com
Mon Feb 26 11:13:07 UTC 2007


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Merge Review: xsane


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=226658





------- Additional Comments From panemade at gmail.com  2007-02-26 06:13 EST -------
Just checked this package in Mock build environment and created patch to SPEC
--- xsane.spec  2007-02-26 16:14:55.000000000 +0530
+++ xsane-modified.spec 2007-02-26 16:15:20.000000000 +0530
@@ -1,7 +1,7 @@
 %define desktop_vendor fedora

 Name: xsane
-Summary: An X Window System front-end for the SANE scanner interface.
+Summary: An X Window System front-end for the SANE scanner interface
 Version: 0.991
 Release: 4%{?dist}
 Source0: http://www.xsane.org/download/%{name}-%{version}.tar.gz
@@ -13,7 +13,7 @@
 License: GPL
 URL: http://www.xsane.org/
 Group: Applications/Multimedia
-Buildroot: %{_tmppath}/%{name}-buildroot
+Buildroot: %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
 BuildRequires: sane-backends-devel gimp-devel libpng-devel libjpeg-devel
 BuildRequires: desktop-file-utils >= 0.2.92
 BuildRequires: libtiff-devel
@@ -30,7 +30,7 @@
 performing the scan and then manipulating the captured image.

 %package gimp
-Summary: A GIMP plug-in which provides the SANE scanner interface.
+Summary: A GIMP plug-in which provides the SANE scanner interface
 Group: Applications/Multimedia
 Requires(post): gimp >= 2:2.2.12-4
 Requires(preun): gimp >= 2:2.2.12-4
@@ -41,7 +41,6 @@
 installed to use this package.

 %prep
-rm -rf %{buildroot}
 %setup -q
 %patch0 -p1 -b .htmlview
 %patch1 -p1 -b .medium-definitions
@@ -100,9 +99,9 @@
 %dir %{_datadir}/sane
 %dir %{_datadir}/sane/xsane
 %{_datadir}/sane/xsane/*eula*
-%{_sysconfdir}/gimp
-%{_sysconfdir}/gimp/plugins.d
-%config %{_sysconfdir}/gimp/plugins.d/xsane.conf
+%dir %{_sysconfdir}/gimp
+%dir %{_sysconfdir}/gimp/plugins.d
+%config(noreplace) %{_sysconfdir}/gimp/plugins.d/xsane.conf

 %post gimp
 if [ -x "%{_sbindir}/gimp-plugin-mgr" ]; then
@@ -372,7 +371,7 @@

 * Mon Jul 26 1999 Tim Powers <timp at redhat.com>
 - update to 0.30
-- added %defattr
+- added %%defattr
 - built for 6.1

 * Thu Apr 22 1999 Preston Brown <pbrown at redhat.com>
===========================================================================

Also you may need to add following line to SPEC for desktop-file-install
        --remove-category Application                           \
Neccesary for warning coming in build.log

Then i even saw rpmlint output is not silent on RPM. It gave me
I: xsane checking
W: xsane rpm-buildroot-usage %build %configure --with-install-root=%{buildroot}
$RPM_BUILD_ROOT should not be touched during %build or %prep stage, as it
will break short circuiting.

W: xsane rpm-buildroot-usage %build %configure --with-install-root=%{buildroot}
--disable-gimp
$RPM_BUILD_ROOT should not be touched during %build or %prep stage, as it
will break short circuiting.


Also Mock build.log is gave me following messages
acinclude.m4:8: warning: underquoted definition of AM_PATH_GTK2
acinclude.m4:8:   run info '(automake)Extending aclocal'
acinclude.m4:8:   or see
http://sources.redhat.com/automake/automake.html#Extending-aclocal
m4/gettext.m4:60: the serial number must appear before any macro definition
m4/gettext.m4:83: the serial number must appear before any macro definition

AND
sed: can't read ./intl/po2tbl.sed.in: No such file or directory


Can you please look at these things?

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.




More information about the Fedora-package-review mailing list