[Bug 221175] Review Request: libisofs - A library to create ISO 9660 disk images

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: libisofs - A library to create ISO 9660 disk images


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=221175





------- Additional Comments From jkeating at redhat.com  2007-01-02 22:23 EST -------
(In reply to comment #4)
> (In reply to comment #3)
> 
> > > - Quite a few executable permissions in -debuginfo source files
> > This is a complaint with upstream that I've asked them to fix.  Is this
> > really a problem that I should chmod the source?
> 
> Well, it took you many more keystrokes to ask that question than fixing it would
> have taken... :).  Why not?  Don't we want proper permissions for all installed
> files?

I'd rather see it fixed upstream.  I'll "fix" it if needbe, but this really
doesn't hurt anything.

> > > - Dubious Cflags in *.pc, should be -I${includedir}/libisofs?
> > Upstream issue, I'll ask them to fix it for the next release.
> 
> Unless I'm missing something, I think it should be patched in this package. 
> Unless of course you prefer waiting for the next upstream release before
> continuing the review.

As I prefer it to be fixed upstream, I'll either get them to do another release,
or at least generate the patch based on an upstream source fix.

> > > - Is the libburn dependency really needed in the main package?
> > I was told yes, but I'll clarify.
> 
> Looks spurious to me.  Nothing is linked against libburn, nor it is dlopened,
> and I don't see anything else in libburn that would be a candidate for
> explaining the dependency.  Caveat: I haven't tried actually using this package
> for anything.

I should have something more for you tomorrow after discussing with upstream. 
I'm just playing package monkey here.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.