[Bug 220393] Review Request: synopsis - Source-code Introspection Tool

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: synopsis - Source-code Introspection Tool


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=220393


mtasaka at ioa.s.u-tokyo.ac.jp changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Review Request: Synopsis -  |Review Request: synopsis -
                   |Source-code Introspection   |Source-code Introspection
                   |Tool                        |Tool




------- Additional Comments From mtasaka at ioa.s.u-tokyo.ac.jp  2007-01-03 12:15 EST -------
Well, still needs a lot of fixes.
Please read the URLs I have already introduced.

* Perhaps this package should use python_sitearch, not
  python_sitelib (see:
  http://fedoraproject.org/wiki/Packaging/Python)

* Check Group. In my opinion:
  main package - Development/Tools
  devel package - Development/Libraries (rather mandatory)
  doc  - Documentation (rather mandatory)

* As I commented above, move all documentation files from
  /usr/share/doc/Synopsis to /usr/share/doc/%{name}-%{version}.

  And.. 3 files "README COPYING NEWS" are included in both
  main package and -doc package (should be only in -main
  package)

* Still Fedora specific compilation flags are not complitely
  passed. (Using CPPFLAGS as well as CFLAGS, CXXFLAGS seems
  to work).

* Still mockbuild fails.
  For me, another requirement of "pkgconfig" for BuildRequires
  seems to work.

* Still directory ownership issue is not treated completely.
  (%{py_sitedir}/Synopsis/Parsers is now owned by any package)
  Please check if all directories created during installation
  of synopsis related rpms are owned correctly by packages.

* The usage of -p option of %post/%postun is on the section
  "Shared libraries" of
  http://fedoraproject.org/wiki/Packaging/ScriptletSnippets

* Would you explain why you create another "-idl" package?
  "Requires" for main package and -idl package are currently
  same, so currently creating -idl subpackage creates no
  benefit.

* Rpmlint complains:
------------------------------------------------------------
W: synopsis-devel summary-ended-with-dot The Synopsis development environment.
------------------------------------------------------------
  Summary should not end with a dot.

Note: when you modify spec file with no "Version" change,
      please increase "Release" number.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.