[Bug 221307] Review Request: python-twisted-lore - Twisted documentation system

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: python-twisted-lore - Twisted documentation system


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=221307


kevin at tummy.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|nobody at fedoraproject.org    |kevin at tummy.com
OtherBugsDependingO|163776                      |163779
              nThis|                            |




------- Additional Comments From kevin at tummy.com  2007-01-04 00:21 EST -------

OK - Package meets naming and packaging guidelines
OK - Spec file matches base package name.
OK - Spec has consistant macro usage.
OK - Meets Packaging Guidelines.
OK - License (MIT)
OK - License field in spec matches
OK - License file included in package
OK - Spec in American English
OK - Spec is legible.
OK - Sources match upstream md5sum:
213569a86fc3d8558605e2847e6378b0  TwistedLore-0.2.0.tar.bz2
213569a86fc3d8558605e2847e6378b0  TwistedLore-0.2.0.tar.bz2.1
e4a7eb4132388a211eaa5b559b60f00005916226  TwistedLore-0.2.0.tar.bz2
e4a7eb4132388a211eaa5b559b60f00005916226  TwistedLore-0.2.0.tar.bz2.1
OK - BuildRequires correct
OK - Package has %defattr and permissions on files is good.
OK - Package has a correct %clean section.
OK - Package has correct buildroot
OK - Package is code or permissible content.
OK - Packages %doc files don't affect runtime.

OK - Package compiles and builds on at least one arch.
OK - Package has no duplicate files in %files.
OK - Package doesn't own any directories other packages own.
OK - Package owns all the directories it creates.
See below - No rpmlint output.
OK - final provides and requires are sane:

SHOULD Items:

OK - Should build in mock.
OK - Should build on all supported archs
OK - Should have dist tag
OK - Should package latest version

Issues:

1. rpmlint says:
E: python-twisted-lore no-binary

Can be ignored.

I don't see any blockers here, so this package is APPROVED.
Don't forget to close this review NEXTRELEASE once it's been
imported and built.


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.