[Bug 209224] Review Request: prelude-manager - Prelude Management server

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: prelude-manager - Prelude Management server


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=209224





------- Additional Comments From mtasaka at ioa.s.u-tokyo.ac.jp  2007-01-05 11:01 EST -------
For 0.9.7.1-2:

* For Requires/BuildRequires:
-------------------------------------------
BuildRequires:  gnutls-devel, libpreludedb-devel, libxml2-devel
-------------------------------------------
  - "gnutls-devel" is not needed because
         libpreludedb-devel requires libprelude-devel
     and libprelude-devel requires gnutls-devel

* Filesystem Layout
  - Please install initscript service file into
    %{_sysconfdir}/rc.d/init.d , not %{_sysconfdir}/init.d .

    For this file:
-------------------------------------------
install -m 750 %{_builddir}/%{name}-%{version}/%{name}.initd
%{buildroot}/%{_sysconfdir}/init.d/%{name}
-------------------------------------------
    - %{_builddir}/%{name}-%{version}/ is not needed
      because the working directory at this stage is there.
    - Why do you write "750"? Anyway the permission of
      this script is set as 0755 accroding to %file section
      and it should be 0755.

* Directory/file ownership
  - Oops, %{_libdir}/prelude-manager/ is not owned by any packages.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.