[Bug 221717] Review Request: agg - C++ rendering framework, move from core to shared

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: agg - C++ rendering framework, move from core to shared


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=221717





------- Additional Comments From pertusus at free.fr  2007-01-06 18:57 EST -------
Some other issues I spotted:

Not blockers (personal preferences, in fact ;-):
* the news file could be shipped even though it only points to a web page
* I would personally replace
rm -f $RPM_BUILD_ROOT/%{_libdir}/*.la
by
rm $RPM_BUILD_ROOT/%{_libdir}/*.la
* and in clean I would have used
rm -rf $RPM_BUILD_ROOT
* I tend to add a trailing / to directories in %files to show that these
are directories and not files, like
%{_includedir}/agg2/


Serious issues:
* there are dependencies missing for agg-devel:
freetype-devel (for ft2build.h), pkgconfig

* %{_libdir}/pkgconfig/ and %{_datadir}/aclocal/ are not owned. pkgconfig
owns %{_libdir}/pkgconfig/, automake owns %{_datadir}/aclocal/ (for
the aclocal dir there are more than one way to fix the issue, but it
must be fixed). 

* in libagg.pc there is 
-Wl,-rpath,${exec_prefix}/lib
Is it really needed?

Still in libagg.pc there is no reference to freetype2. Maybe there
should be a
Requires.private: freetype2
?

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.