[Bug 221727] Review Request: cssed - CSS editor and validator

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: cssed - CSS editor and validator


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=221727





------- Additional Comments From mr.ecik at gmail.com  2007-01-07 09:03 EST -------
REVIEW:
 * rpmlint gives me following result:
W: cssed-devel no-documentation
can be ignored because of lack of any devel-related documentation
 * I have no objection to name of package and spec file
 * package is licensed under a GPL license and the license file is included
into %doc
 * package builds fine in mock fc6/x86_64
 * sources match upstream (md5: ff7c818d1f819b7d76b4f714be64e08e)
 * locales are handled well
 * all directories are properly owned
!* %clean section presents but looks bad, you should change it to
rm -rf %{buildroot}
 * %defattr macro presents in all %files sections
 * macros used well
 * -devel subpackage presents and looks good
!* bad icon tag in desktop-file

THINGS to do:
 * change %clean section
 * you have used cssed.png entry in desktop.file but that file doesn't exist.
It seems to me that the best way would be changing it to
/usr/share/cssed/pixmaps/cssed-about.png

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.