[Bug 214830] Review Request: Limph - PHP network host monitor

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: Limph - PHP network host monitor


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=214830





------- Additional Comments From orion at cora.nwra.com  2007-01-09 14:27 EST -------
Sorry for the delay.  On travel and then the holidays.

- $ rpmlint -i limph-hostagent-1.9.4-1.fc6.noarch.rpm
E: limph-hostagent executable-marked-as-config-file /etc/cron.hourly/limph-hostagent
Executables must not be marked as config files because that may
prevent upgrades from working correctly. If you need to be able to
customize an executable, make it for example read a config file in
/etc/sysconfig.

- You're still creating the tmp dir:

mkdir -p %{buildroot}%{limphdir}/tmp

- Both limph and limph-hostagent own /usr/share/limph/host_agent.php.  You need
an %exclude in the limph files section.

- Does limph-hostagent require limph to run?  Looks like it does need
config.php.  Add the appropriate requires.


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.