[Bug 221957] Review Request: ksshaskpass - A KDE version of ssh-askpass with KWallet support

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: ksshaskpass - A KDE version of ssh-askpass with KWallet support


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=221957





------- Additional Comments From gauret at free.fr  2007-01-09 17:44 EST -------
> Offhand, you don't need:
> # work around an improper ${kdelibsuff}
> export QTLIB=${QTDIR}/lib QTINC=${QTDIR}/include
> anymore.  qt was fixed wrt a long time ago. (:

Great ! That was abusive cut'n'paste...

About the environement script, I just took the example from the one provided by
the openssh-askpass package.
I agree about moving it to /etc/kde/env (I didn't know of this dir, interesting
:) ), but I don't think adding an ssh-add call to it is a good idea, for the
following reasons :
 - scripts in env should not start programs, only define environment vars.
Startup applications should be in ~/.kde/Autostart or /usr/share/autostart.
 - some people dislike ssh-agent, because it knows about their password. By
calling ssh-add in the script, we would force it on every user on the system.
that's why I added a README.Fedora with usage instructions.

> We definitely don't want SSH_ASKPASS defined for console/text sessions

Actually, if you call ssh-add from an interactive terminal, it will not use the
SSH_ASKPASS application, it will just prompt for the password. That's why the
openssh-askpass package defines it in /etc/profile.d

Upstream provides an sha1sum on this page : http://hanz.nl/p/program , you can
check it too if you want.

* Tue Jan 09 2007 Aurelien Bompard <abompard at fedoraproject.org> 0.3-2
- remove useless workaround
- put the environment script in /etc/kde/env

http://gauret.free.fr/fichiers/rpms/fedora/ksshaskpass.spec 
http://gauret.free.fr/fichiers/rpms/fedora/ksshaskpass-0.3-2.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.