[Bug 219025] Review Request: ntop - A network traffic probe similar to the UNIX top command

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: ntop - A network traffic probe similar to the UNIX top command


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=219025





------- Additional Comments From mtasaka at ioa.s.u-tokyo.ac.jp  2007-01-10 11:43 EST -------
Well, let's start again.

Well, for 3.2-7:

* Conditional dependencies:

  - Mockbuild log (on FC-devel i386) says:
----------------------------------------
checking security/pam_appl.h usability... no
checking security/pam_appl.h presence... no
----------------------------------------
    These are included in pam-devel.

*******************************************************************
*
* WARNING:  One or more items required for the xmldump plugin are 
*           missing:
*
*                  libxml2.so or libxml2.a...yes
*                  gdome.h...yes
*                  libgdome.so or libgdome.a...yes
*                  glib.h...yes
*                  libglib.so or libglib.a...no
*                  glibconfig.h...yes
*
*           (yes means it was found, no means it was not found)
*
*       ntop will run just fine without this plugin.
*
*>>>    If you want to use the xmldump plugin,
*
*???     1. Install the necessary headers and libraries.
*???    and rerun ./configure
*
*******************************************************************
     libglib.so is included in glib-devel.

* BuildRequires:
--------------------------------------------------------
redundant package <= package which requires it
tcp_wrappers         net-snmp-devel
autoconf             automake
automake             libtool 
     (However, I don't mind if you want to write "automake"
      explicitly)
pkgconfig            glib2-devel
glib2-devel          gdome2-devel
--------------------------------------------------------

* Encoding:
---------------------------------------------------------
/usr/share/doc/ntop-3.2/ChangeLog:  ISO-8859 English text
---------------------------------------------------------
  - Please change the encoding to UTF-8.

* For SEGV issue Patrice saw:
  Oh, I got SEGV, too! However, not completely reproducible,
  however, for me this happens at the same point at last.

  One example:
----------------------------------------------------------
Program received signal SIGABRT, Aborted.
[Switching to Thread -1273857136 (LWP 20547)]
0x00f58402 in __kernel_vsyscall ()
(gdb) bt
#0  0x00f58402 in __kernel_vsyscall ()
#1  0x00bd8c70 in *__GI_raise (sig=6) at ../nptl/sysdeps/unix/sysv/linux/raise.c:64
#2  0x00bda4c1 in *__GI_abort () at abort.c:88
#3  0x00c0e29b in __libc_message (do_abort=2, 
    fmt=0xcd21c4 "*** glibc detected *** %s: %s: 0x%s ***\n")
    at ../sysdeps/unix/sysv/linux/libc_fatal.c:170
#4  0x00c15e29 in _int_free (av=0xcfc120, mem=0x82e67a0) at malloc.c:5774
#5  0x00c19650 in *__GI___libc_free (mem=0x82e67a0) at malloc.c:3552
#6  0x00f726cc in ntop_safefree (ptr=0x81d6154, file=0xfaa9fc "util.c",
line=2601) at leaks.c:188
#7  0x00f964b9 in traceEvent (eventTraceLevel=3, file=0xfa73fd "ntop.c", line=136, 
    format=0xfa7d40 "THREADMGMT[t%lu]: NPS(%d,%s): pcapDispatch thread
terminated [p%d]")
    at util.c:2601
#8  0x00f75a62 in pcapDispatch (_i=0x0) at ntop.c:136
#9  0x00d382db in start_thread (arg=0xb4127b90) at pthread_create.c:296
#10 0x00c7d24e in clone () from /lib/libc.so.6
----------------------------------------------------------

    And.. in util.c:
----------------------------------------------------------
  2598        }
  2599  
  2600        if (myGlobals.logView[myGlobals.logViewNext] != NULL)
  2601          free(myGlobals.logView[myGlobals.logViewNext]); <- PROBLEM
HAPPENED HERE!!
  2602  
  2603        myGlobals.logView[myGlobals.logViewNext] = strdup(buf);
  2604  
  2605        myGlobals.logViewNext = (myGlobals.logViewNext + 1) %
CONST_LOG_VIEW_BUFFER_SIZE;
  2606  
  2607        if(myGlobals.logViewMutex.isInitialized) {
----------------------------------------------------------
    It seems that myGlobals.logView is not initialized correctly
    by NULL.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.