[Bug 222175] Review Request: six - Hex playing program

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: six - Hex playing program


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=222175





------- Additional Comments From mr.ecik at gmail.com  2007-01-10 14:44 EST -------
It looks like there's some missing scriptlets. You ought to read
http://fedoraproject.org/wiki/Packaging/ScriptletSnippets to know most of
them.
Firstly, your package installs icons into %{_datadir}/icons/{hicolor,locolor}.
It means that you have to add following lines to your spec file:
%post
touch --no-create %{_datadir}/icons/hicolor || :
%{_bindir}/gtk-update-icon-cache --quiet %{_datadir}/icons/hicolor || :
%{_bindir}/gtk-update-icon-cache --ignore-theme-index --quiet %{_datadir}/icons/
hicolor || :

%postun
touch --no-create %{_datadir}/icons/hicolor || :
%{_bindir}/gtk-update-icon-cache --quiet %{_datadir}/icons/hicolor || :
%{_bindir}/gtk-update-icon-cache --ignore-theme-index --quiet %{_datadir}/icons/
hicolor || :

Also, there's a "MimeType=" entry so you need to add:
%post
update-mime-database %{_datadir}/mime &> /dev/null || :

%postun
update-mime-database %{_datadir}/mime &> /dev/null || :

And the normal review process:
 * sources match upstream (457028e8040f030b8f2cd6a65d04bab9)
 * rpmlint is silent
 * dist tag present
 * build root correct
 * license field matches the actual license and is included in %doc
 * BuildRequires looks good as package builds in mock (fc6/x86_64)
 * provides and requires are sane
 * no shared libraries
 * not relocatable
 * it owns all directories well

Package contains check procedure, so you can create %check section with `make
check` inside it.

Thus, THINGS you need to do are:
 - add missing %post and %postun sections
 - add %check section


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.