[Bug 222070] Review Request: prewikka - Prelude IDS Management Console
bugzilla at redhat.com
bugzilla at redhat.com
Thu Jan 11 19:09:41 UTC 2007
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: prewikka - Prelude IDS Management Console
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=222070
------- Additional Comments From mtasaka at ioa.s.u-tokyo.ac.jp 2007-01-11 14:09 EST -------
I have not rebuilt this package, however..
* Requires:
-----------------------------------------
Requires: python-abi = .....
-----------------------------------------
- This is not needed any more because rpmbuild automatically
adds python requirement as "Requires: python(abi) = ..."
* Bytecompiled python objects .pyc and .pyo files should have 0644
permission.
* At %install stage:
------------------------------------------
rm -rf %{buildroot}/%{python_sitearch}/%{name}/templates/__init__.py
------------------------------------------
Why is this needed?
* Documentation:
-----------------------------------------
mkdir -p %{buildroot}%{_defaultdocdir}/%{name}-%{version}
mkdir -p %{buildroot}%{_defaultdocdir}/%{name}-%{version}/apache
cp -p AUTHORS README NEWS HACKING.README \
%{buildroot}%{_defaultdocdir}/%{name}-%{version}
cp -p doc/apache.conf %{buildroot}%{_defaultdocdir}/%{name}-%{version}/apache/
-----------------------------------------
These can be done by:
-----------------------------------------
%install
......
mkdir apache
cp -p doc/apache.conf apache/
......
%files
%doc AUTHORS README NEWS HACKING.README
%doc apache/
......
-----------------------------------------
By the way, is it really needed to move apache.conf documentation
to apache directory (by creating apache directory)?
* Other dependency
This package requires either libpreludedb-mysql/pgsql/sqlite
package. Also, it seems that prewikka-httpd will not work
only by installing one of them. To use prewikka-httpd some
setting seems still needed.
One solution is that you write a document "README.fedora" which
explains that prewikka user needs to install either a package
according to what database he/she will use and some settings are
needed according to what installed (at this stage, you can
say "the details of settings are on http://..., however,
you must write to the document at least what package user should
install)
By the way, if prewikka-httpd is used only by privileged user,
it should be installed under %{_sbindir}.
--
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.
More information about the Fedora-package-review
mailing list