[Bug 221873] Review Request: cgdb - A curses-based interface to the GNU Debugger (GDB)

bugzilla at redhat.com bugzilla at redhat.com
Mon Jan 15 16:29:23 UTC 2007


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: cgdb - A curses-based interface to the GNU Debugger (GDB)


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=221873





------- Additional Comments From mtasaka at ioa.s.u-tokyo.ac.jp  2007-01-15 11:29 EST -------
Well, for -8,

* Please keep the name of "htdocs", i.e. the entry of %doc
  should be "htdocs", not "htmldocs".
* Use "cp -p" to keep timestamps.
* For Source1:
  If this file is available from some URL, please specify the URL
  like Source0. If this file is something you created by ImageMagick,
  for example, please note how you created the file briefly as
  comments in spec file.
* For cgdb.txt:
  Well, I confirmed that this file is needed by 
  ./doc/htdocs/documentation.shtml, so actually
---------------------------
cp -p doc/cgdb.txt htdocs (please copy to this directory)
---------------------------
  is needed. And as you can see in ./cgdb/src/interface.c:
---------------------------
  1525  void
  1526  if_display_help (void)
  1527  {
  1528    char cgdb_help_file[MAXLINE];
  1529    int ret_val = 0;
  1530  
  1531    fs_util_get_path (PKGDATADIR, "cgdb.txt", cgdb_help_file);
  1532    ret_val = source_set_exec_line (src_win, cgdb_help_file, 1);
  1533    if (ret_val == 0)
  1534      if_draw ();
  1535    else if (ret_val == 5)        /* File does not exist */
  1536      if_display_message ("No such file: %s", 0, cgdb_help_file);
  1537  }
  1538  
---------------------------
  This file is also needed by cgdb binary, so please don't
  remove this from %{_datadir}/cgdb.

  After you fix these, you can import this to Fedora Extras.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.




More information about the Fedora-package-review mailing list