[Bug 222388] Review Request: gnucash - personal finance management

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: gnucash - personal finance management


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=222388





------- Additional Comments From notting at redhat.com  2007-01-15 11:35 EST -------
(In reply to comment #4)
> Issues: 
> 
> 1. Is this package built often from svn snapshots? 
> ie, are the %if's for svn building needed anymore?

It was in the run-up to 2.0. I haven't really built it much from SVN since then.
It could be removed as it does dirty up the spec file a lot.

> 2. Is the 
> %defattr(-,root,root,755)
> needed? Or will
> %defattr(-,root,root,-) 
> work?

755 is the default, so just (-,root,root) should work. Fixed.

> 3. Does rpm fail at finding the perl requires?
> Is the '%define __perl_requires  %{nil}' still needed?

Ooh, good catch. This was done to avoid generating perl requires on something
that we didn't ship that was satisfied by installing an Extras package. I'll try
without it to see if it can be removed.

> 4. Doesn't seem to build here in mock/devel. 
> The build.log has at the end: 
> 
> checking for libgsf-1 >= 1.12.2 libgsf-gnome-1 >= 1.12.2... Package libgsf-
> gnome-1 was not found in the pkg-config search path. Perhaps you should add the 
> directory containing `libgsf-gnome-1.pc' to the PKG_CONFIG_PATH environment 
> variable No package 'libgsf-gnome-1' found
> configure: error: Library requirements (libgsf-1 >= 1.12.2 libgsf-gnome-1 >= 
> 1.12.2) not met; consider adjusting the PKG_CONFIG_PATH environment variable if 
> your libraries are in a nonstandard prefix so pkg-config can find them.
> error: Bad exit status from /var/tmp/rpm-tmp.55382 (%build)
> 
> Looks like missing 'Buildrequires: libgsf-gnome-devel'
> Adding that gets it building on devel here. 

Hm, wonder if that was split. Will check.

> 5. The "--disable-sql" seems to have been added back in fc4. 
> Is it worth re-enabling now?

The SQL support is deprecated, lacking a maintainer,  and not supported upstream.

> 6. Should the --with-cairo be commented in or out? 

It's an option that the builtin libgoffice/libgsf snapshots took, that ended up
not working. (In Core, we built this with the builtin goffice support.) As we're
using separate goffice/gsf, the comment can be removed.

> 7. Our friend rpmlint says: 
> 
> E: gnucash obsolete-not-provided gnucash-backend-postgres
> 
> I don't know how long ago the gnucash-backend-postgres was removed, 
> but it might be good to provide gnucash-backend-postgres as long 
> as the obsolete is still there.

Well, we don't provide the functionality, and it was always built from
the gnucash SRPM. I'm not seeing how you could get into a situation where
you'd need the provide.

> E: gnucash non-executable-script /usr/share/xml/gnucash/xsl/vcard-
> gnccustomer.pl 0644
> 
> Might nuke the #!/usr/bin/perl from this script or make it executable? 

It's an example script, so having it non-executable makes sense to me. (Not sure
why they install it in datadir instead of doc) 

> E: gnucash shell-syntax-error-in-%post
> 
> There seems to be a unattached
> done
> in the %post. 

Good catch, fixed.

> W: gnucash unversioned-explicit-obsoletes gnucash-backend-postgres
> 
> typically it's good to add a version thats being obsoleted. 

See above - not sure how you'd get to where it's needed.

> E: gnucash hardcoded-library-path in /usr/lib/debug
> 
> Is the '%exclude /usr/lib/debug' needed? 

Otherwise %{_libdir}/* will pick it up.

> E: gnucash-debuginfo script-without-shebang /usr/src/debug/gnucash-2.0.4/src/
> import-export/import-commodity-matcher.c
> 
> Should be mode 644?

Possibly. Not sure it matters in debuginfo, but fixed.

> 8. .la files should be nuked unless there is a good reason to keep them. 

gnucash uses g-wrap, which uses libltdl to load shared objects. Unfortunate, but
required.

> 9. It looks like the docs aren't released for each main gnucash release. 
> Perhaps it would make sense to split them into a gnucash-docs package? 
> That would save people 10MB of update when just gnucash was updated. 

Not sure how it helps when you have the main package always requiring gnucash-docs.



-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.