[Bug 222521] Review Request: IceWM - Lightweight Window Manager.

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: IceWM -  Lightweight Window Manager.


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=222521





------- Additional Comments From pertusus at free.fr  2007-01-16 15:33 EST -------
(In reply to comment #9)
> - Tab size:
> I'm using ts=4 - which may cause a problem if/when ts=8.
> (I know that there's a world war going on about tab size/stop).
> Is there a unified SPEC format that dictates the tab size and/or tabs vs. spaces?

No, it is your personal preference. I prefer using spaces, but there
is nothing that dictates the appearance of the spec file, except
that it should remain legible, which is the case here.

> - CXXFLAGS:
> AFAICS these are the CXXFLAGS generated by automake.

No, there is no use of automake in icewm. These seems to be
set in ICE_CXX_FLAG_ACCEPT in configure.in.

> - Themes:
> Due to bandwidth constraints, I don't use mock. At least on my dev
> machine, themes are packed into the RPM.

Oops, indeed they are, I missed them.

> - KDE:
> Fedora is GNOME centric. 

No. It is admittedly freedesktop centric, but nothing more.

> While I'm a KDE user myself, I see little reason to
> force users to install the KDE dep-chain when they are looking for a
> lightweight WM.

Nothing from gnome should be installed either. Only used if present.

> In short, KDE is removed from menu.in.

Please try to arrange things such that gnome and kde stuff is used
if they are installed, and that things go smoothly if they aren't.
If I am not wrong this is what is currently done by using 
 /usr/share/desktop-directories/

> - Default menu:
> * Browser:
> AFAIK Firefox is the default browser in Fedora. Added as the default browser
> in the main menu. (htmlview is less useful)

htmlview is much smarter than firefox to chose the right browser.
The fact that firefox is the default browser doesn't means that
it should be used.

> Should we consider elinks instead?

No, let's let htmlview do the work. I guess you can setup things to use
elinks through htmlview... Have a look at the htmlview script, and try to
run it if you are not convinced.

> * Misc:
> I'm also getting idesk and gmrun reviewed - once they are in, I'll add them as
> BR/R in an attempt to create a fuller DE environment.

The window manager is not the place where the desktop should be 
set up. What you need is a group in the comps file, but please try to 
minimize the window manager dependencies.

The other way around is also true, apps should not depend on a particular
window manager and most of the time not on a window manager at all.

> * Tue Jan 16 2007 <gilboad AT gmail DOT com> - 1.2.30-4
> - Fix man page name.

Please don't do the gziping of man pages yourself, just install
them and let rpm handle them.

> - Push default configuration into /etc/icewm

That's not right. Please leave the default config files in %_datadir,
just create and own the %{_sysconfdir}/icewm directory. You can
use complicated things  with noverify, if you like, for files that
are meant to be in that directory, but I don't think it is worth it.

> - Remove default KDE support. (GNOME centric distribution -
>     no need to drag the KDE dep-chain in a lightweight WM)

Please no. I believe kde is used currently, although I haven't tested.
If you feel brave, you could have a look at how pyxdg is used to
create menus in fluxbox-xdg-menu and try to hack something similar... 

> - Add missing firefox icon. (No source - manual convert)

Beware of the trademark issues surrounding firefox.

> - Add missing gnome-menus. (required for GNOME2 menus)

Not sure that it is needed. It would be certainly better if it wasn't
needed, and only desktop neutral freedesktop stuff was needed. In fact
it seems that it is what is done. You should in my opinion depend
on redhat-menus instead (there is a directory ownership issue, I just
filled Bug 222905).

> - Fix missing lang support.

It is not completly fixed.
There should be

%files -f %{name}.lang

and no

%{_datadir}/locale/*/LC_MESSAGES/*


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.