[Bug 222521] Review Request: IceWM - Lightweight Window Manager.

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: IceWM -  Lightweight Window Manager.


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=222521





------- Additional Comments From gilboad at gmail.com  2007-01-18 12:26 EST -------
* CXXFLAGS:
I checked it back when you first pointed it out. Nothing too major. Mostly added
warning and reduced C/Cxx bloat.
The permissive and no-exceptions are... a bit odd, but neither seem to pose any
danger.

* "What about asking upstream for a possibility to have something like 
menuprog, but which is called only when starting icewm?"

I think I have a better solution (at least short-term one): By default
icewm-session tries to execute the "startup" script (if it exists) within the
user's .icewm directory.
While not perfect, I should be able to create a default script that will use the
icewm-xdg-menu.py to generate static menu items.
However, such a solution may require recursive bash scripting and I rather take
the time to think about it.
(Plus, an ideal script should also generate the icon-line for each and every
menu item).

* "did you check the trademark issues with redhat-web-browser artwork?"

OK. I vented it with my sponsor and the icon is GPL. No problems there.
However, I decided it's useless the pack the icon twice.
I just added redhat-artwork to REQ and pointed the toolbar/menu to the original
icon(s).

* GPL/LGPL:

Somehow I got the idea that the xdg menu script was GPL, and therefore I decided
to switched everything to GPL to keep everything kosher.
Can't seem to find it now. My mistake, I guess.
Switching back to LGPL.

* Signature:

Bad habit of mine.
It helps me locate my own posts in long threads.


* Tue Jan 18 2007 <gilboad AT gmail DOT com> - 1.2.30-6
- Change license back to LGPL.
- Change summery.
- New sub-package: -gnome. (GNOME menu support.)
- Missing REQ: xterm.
- Missing REQ: htmlview.
- Remove redundant %%_sysconf section.
- Remove redundant redhat-xxx icons.
- New REQ: redhat-artwork. (icons)
- Better man pages handling.
- Customize keys to better match fedora.
- New REQ: eject. (keys)
- New REQ: alsautils. (keys)


Spec URL: http://gilboadavara.thecodergeek.com/icewm.spec
SRPM URL: http://gilboadavara.thecodergeek.com/icewm-1.2.30-6.src.rpm


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.