[Bug 222374] Review Request: paprefs - Management tool for PulseAudio

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: paprefs - Management tool for PulseAudio


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=222374





------- Additional Comments From foolish at guezz.net  2007-01-22 20:09 EST -------
This is not a review 

I think calling the package pulseaudio-preferences would be more intuitive. I
wouldn't know to install paprefs to get the pulseaudio preferences. PulseAudio
website even refers to paprefs as pulseaudio volume control on the front page.
According to PackageNamingGuidelines: "If a new package is considered an "addon"
package that enhances or adds a new functionality to an existing Fedora Core or
Fedora Extras package without being useful on its own, its name should reflect
this fact." 

Some other issues to adress: 
* BuildRequires for lynx is commented out, lynx is needed to build
* BuildRequires for desktop-file-utils commented out for some reason

* "--add-category="X-Fedora" --vendor="  is depriciated, you should also add
"--remove-category Application"

* %dir is for owning a dir, but not the contents of that dir. since this package
owns all files in %{_datadir}/paprefs, %dir %{_datadir}/paprefs is not needed.

* Doesn't Require: any of the pulseaudio stack, while paprefs runs without it, I
would imagine it to be pretty useless without pulseaudio actually installed

Good: rpmlint silent, source matches upstream, spec looks good, runs, includes
licencing information, 

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.