[Bug 221188] Review Request: pdns-recursor - Modern, advanced and high performance recursing/non authoritative nameserver

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: pdns-recursor - Modern, advanced and high performance recursing/non authoritative nameserver


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=221188





------- Additional Comments From kevin at tummy.com  2007-01-23 22:54 EST -------

OK - Package meets naming and packaging guidelines
OK - Spec file matches base package name.
OK - Spec has consistant macro usage.
OK - Meets Packaging Guidelines.
OK - License (GPL)
OK - License field in spec matches
OK - License file included in package
OK - Spec in American English
OK - Spec is legible.
OK - Sources match upstream md5sum:
439a10639f53def0ba47c0851e4a2671  pdns-recursor-3.1.4.tar.bz2
439a10639f53def0ba47c0851e4a2671  pdns-recursor-3.1.4.tar.bz2.1
d1fa344ec5f2feb12397361f92b011a0cb726d48  pdns-recursor-3.1.4.tar.bz2
d1fa344ec5f2feb12397361f92b011a0cb726d48  pdns-recursor-3.1.4.tar.bz2.1
OK - BuildRequires correct
OK - Package has %defattr and permissions on files is good.
OK - Package has a correct %clean section.
OK - Package has correct buildroot
OK - Package is code or permissible content.
OK - Packages %doc files don't affect runtime.

OK - Package compiles and builds on at least one arch.
OK - Package has no duplicate files in %files.
OK - Package doesn't own any directories other packages own.
OK - Package owns all the directories it creates.
OK - No rpmlint output.
See below - final provides and requires are sane:

SHOULD Items:

OK - Should build in mock.
OK - Should build on all supported archs
OK - Should have dist tag
OK - Should package latest version

Issues:

1. The Source URL doesn't seem to work for me.

Should be:
http://downloads.powerdns.com/releases/pdns-recursor-3.1.4.tar.bz2

(note: releases, not release)

2. Your debuginfo files are all empty. Not sure why that is, but
I think it deserves some investigation.

3. I assume the
Provides:               powerdns-recursor = %{version}-%{release}
is for upstream or other project released rpms?

4. Is it ok for this package to run as user 'pdns', which is
the same as the 'pdns' package. If they are both on the same
machine could there be security implications? Perhaps this
package should use a 'pdns-recursor' user instead?


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.