[Bug 224271] Review Request: rhts - A system for developing automated tests

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: rhts - A system for developing automated tests


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=224271





------- Additional Comments From lxtnow at gmail.com  2007-01-24 20:21 EST -------
=== MUST Fix ===

* You don't need to define version and release above, just past them in the      
  right way "version:   and  release:    "
* "Group:   QA" not valide.
* fields "url:" is missing.
* fields Source0 must be point to the full location of the tarball for check up.
* "# snapshot" can be remove.
* fields BuildRoot: not complete and not be point to your login (error while
build)= "make: *** No rule to make target `install-noarch'.  Stop."

* Things which has already mentioned by Michael Schwendt.
* make install-noarch not really need it, just an make install.
----
rpmlint output from srpm:
----
W: rhts non-standard-group QA
W: rhts no-url-tag
W: rhts unversioned-explicit-obsoletes rhts-testhelpers
W: rhts unversioned-explicit-provides rhts-testhelpers
W: rhts unversioned-explicit-obsoletes rhts-testhelpers-developer
W: rhts unversioned-explicit-provides rhts-testhelpers-developer
W: rhts rpm-buildroot-usage %build [ "$RPM_BUILD_ROOT" != "/" ] && [ -d
$RPM_BUILD_ROOT ] && rm -rf $RPM_BUILD_ROOT;
W: rhts rpm-buildroot-usage %build DESTDIR=$RPM_BUILD_ROOT make
E: rhts no-cleaning-of-buildroot %install
W: rhts mixed-use-of-spaces-and-tabs (spaces: line 1, tab: line 31)
-----
rpmlint output from rhts-test package:
-----
W: rhts-test-env no-url-tag
W: rhts-test-env no-documentation
E: rhts-test-env dir-or-file-in-mnt /mnt/tests
E: rhts-test-env script-without-shebang /usr/share/rhts/lib/rhts-make.include
E: rhts-test-env dir-or-file-in-mnt /mnt/scratchspace
E: rhts-test-env dir-or-file-in-mnt /mnt/testarea
E: rhts-test-env non-standard-dir-perm /mnt/testarea 01777
-----
rpmlint output from rhts-python package:
-----
W: rhts-python no-url-tag
W: rhts-python no-documentation
E: rhts-python non-executable-script
/usr/lib/python2.4/site-packages/rhts/testinfo.py 0644
-----
* all warning and error must be fix.
* in field %files, you don't need to past each files, main location it enough.


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.