[Bug 222594] Review Request: seedit: SELinux Policy Editor
bugzilla at redhat.com
bugzilla at redhat.com
Fri Jan 26 04:36:37 UTC 2007
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: seedit: SELinux Policy Editor
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=222594
------- Additional Comments From ynakam at hitachisoft.jp 2007-01-25 23:36 EST -------
Thank you for review!
>* Requires:
> - gnome-python2 (required by -gui)
> Please check if this is really required. By checking with
> "grep import" no module seems to be installed from
> gnome-python2.
Fixed, I am not using it now.
>* File ownership issue/scriptlet
> And please check if any other file which should be marked
> as such exists so that all _unnessary_ files are correctly
> removed on the complete removal of seedit.
Fixed, I listed rbac-init, need-init in %ghost.
>* Version dependency requirement
>-------------------------------------------------------
>Requires: seedit >= 2.1.0
>-------------------------------------------------------
> - Usually these types of requirement should be version->release
> dependent, i.e.
>-------------------------------------------------------
>Requires: %{name} = %{version}-%{release}
>-------------------------------------------------------
Fixed.
>Requires: %{name} = %{version}-%{release}
did not work("=" does not work),
so I used
Requires: %{name} >= %{version}-%{release}
>* Desktop file:
>-------------------------------------------------------
>Categories=Application;SystemSetup;X-Red-Hat-Base;
>-------------------------------------------------------
> Both categories: "Application" "X-Red-Hat-Base" "SystemSetup"
> are now deprecated and these should be removed.
Fixed.
>* Timestamps
> - These packages include many text files, image files
> and keeping timestamps on these files are generally
> preferred. Please fix so that the timestamps on these
> files are kept.
>
>-------------------------------------------------------
>install -m 0644 %{SOURCE2} ${RPM_BUILD_ROOT}%{_datadir}/pixmaps/seedit-gui.png
>-------------------------------------------------------
> Also, please use "install -p".
Fixed both spec file and Makefiles.
>* Macros
>-------------------------------------------------------
>%define selinuxconf /etc/selinux/config
>%define auditrules /etc/audit/audit.rules
>-------------------------------------------------------
> Please check if the directory /etc should be written
> as hardcoded or as %{_sysconfdir}.
Fixed.
>* Pam requirement
> %{_sysconfdir}/pam.d/seedit-gui includes:
>-------------------------------------------------------
>auth include config-util
>-------------------------------------------------------
> This sentence requires pam >= 0.80 so I think
> adding "Requires: pam >= 0.80" is preferable.
Yes, in old pam, it does not work.
Fixed.
>* $RPM_BUILD_ROOT vs %{buildroot}
> Please use one, not both.
Fixed. Using only %{buildroot}
Updated version:
* SPEC
http://prdownloads.sourceforge.jp/selpe/23577/seedit.spec
* SRPM
http://prdownloads.sourceforge.jp/selpe/23577/seedit-2.1.0-0.14.beta6.6.src.rpm
--
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.
More information about the Fedora-package-review
mailing list