[Bug 225126] Review Request: dxpc - A Differential X Protocol Compressor

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: dxpc - A Differential X Protocol Compressor


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=225126





------- Additional Comments From bugs.michael at gmx.net  2007-01-29 13:53 EST -------
In addition to the findings from comment 3, a bit of clean-up could
be applied to the spec file. All non-blockers, though:

> BuildRequires: lzo-devel >= 1.08

lzo is >= 1.08 in Fedora, at least in Fedora Extras >= 3.

> %if "%{?fedora}" > "4"

Fedora <= 4 has reached end-of-life.

> %install
> [ "%{buildroot}" != "/" ] && rm -rf %{buildroot}
> %makeinstall

Instead of %makeinstall, prefer the standard

  make DESTDIR="%{buildroot}" install

whenever it works.

These can all be fixed in CVS, however, so feel free to continue with
the process at step 10: http://fedoraproject.org/wiki/Extras/Contributors

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.