[Bug 240557] Review Request: ocaml-findlib - Objective CAML package manager and build helper

Sun Jul 8 03:08:57 UTC 2007

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: ocaml-findlib - Objective CAML package manager and build helper

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=240557

------- Additional Comments From lxtnow at gmail.com  2007-07-07 23:08 EST -------
=== REQUIRED ITEMS ===

 [ OK ] Package successfully compiles and builds on at least one supported arch.
 [ OK ] Mock built on x86_64 [Devel]
 [ OK ] Package is named according to the Package Naming and Ocaml Guidelines.
 [ OK ] Spec file name match the packaging naming Ocaml guidelines.
 [ Ok ] Package meets the Packaging Guidelines.
 [ OK ] Package is not relocatable.
 [ OK ] Buildroot is correct
 [ OK ] Package is licensed with an open-source compatible license.
 [ OK ] License field in the package spec file matches the actual license.
     License type: GPL
 [ OK ] Spec file is legible and written in American English.
 [ OK ] Package is not known to require ExcludeArch.
 [ OK ] All build dependencies are listed in BuildRequires.
 [ OK ] The spec file handles locales properly.
 [ OK ] ldconfig called in %post and %postun if required.
 [ OK ] Package must own all directories that it creates.
 [ OK ] Package requires other packages for directories it uses.
 [ OK ] Package does not contain duplicates in %files.
 [ OK ] Permissions on files are set properly.
 [ OK ] Package has a %clean section.
 [ OK ] Package consistently uses macros.
 [ OK ] Package contains code, or permissable content.
 [ SKIP ] Large documentation files are in a -doc subpackage, if required.
 [ OK ] Package uses nothing in %doc for runtime.
 [ SKIP ] Header files in -devel subpackage, if present.
 [ SKIP ] Static libraries in -devel subpackage, if present.
 [ SKIP ] Package requires pkgconfig, if .pc files are present.
 [ SKIP ] Development .so files in -devel subpackage, if present.
 [ CHECK ] Fully versioned dependency in subpackages, if present.
 [ OK ] Package does not contain any libtool archives (.la).
 [ SKIP ] Package contains a properly installed %{name}.desktop file.
 [ OK ] Package does not own files or directories owned by other packages

According to OCaml Packaging Guideline:

 [ OK ] OCaml modules / libs should be named ocaml-foo.
 [ OK ] The spec file should still build bytecode libraries and binaries.
 [ OK ] Should Test if the native compiler is present.
 [ OK ] main package should contain files matching all files which mentioned in 
        OCaml guideline.
 [ OK ] -devel sub-package Should contains all files which're mentioned in OCaml

       guidelines.

 [ CHECK ] Requires:
rpmlib(PayloadFilesHavePrefix) <= 4.0-1 rpmlib(CompressedFileNames) <= 3.0.4-1
rpmlib(VersionedDependencies) <= 3.0.3-1
Requires: /bin/sh libc.so.6()(64bit) libc.so.6(GLIBC_2.2.5)(64bit)
libc.so.6(GLIBC_2.3)(64bit) libc.so.6(GLIBC_2.3.4)(64bit)
libc.so.6(GLIBC_2.4)(64bit) libdl.so.2()(64bit) libdl.so.2(GLIBC_2.2.5)(64bit)
libm.so.6()(64bit) libm.so.6(GLIBC_2.2.5)(64bit) ocaml(Array) =
aa8e3cd5824f9bb40b93fcd38d0c95b5 ocaml(Big_int) =
992d682669507b99e689b5a2188c0b9a ocaml(Buffer) =
f6cef633ea14963b84b79c4095c63dc3 ocaml(Char) = e98bc9c9e918a84b3c1a5a122d42fac1
ocaml(Consistbl) = 47f9cdffda6ba2de99c8e9f0c0c1b34d ocaml(Digest) =
a5dd2d89492338578de12105e88c803f ocaml(Env) = 6d0215253b3fde95601c34944cacb607
ocaml(Filename) = 633a1e7f590ff5e95124293dbef3b476 ocaml(Format) =
35fe566f7a37d8991a5c822bd1463949 ocaml(Hashtbl) =
083f2c94b44ff4e0b3220aaea6a783b4 ocaml(Ident) = ba1acc56fc179d27bd55278cbc2abf40
ocaml(Lexing) = b1793496643444d3762dd42bebe2cfe3 ocaml(List) =
da1ce9168f0408ff26158af757456948 ocaml(Location) =
eed044ad1204a633caad97bdd9048f8c ocaml(Longident) =
46fb8aad4fb2c12a0f301b02d8139f07 ocaml(Map) = dedde7683d54ae7db1eb97cc868dd047
ocaml(Nat) = 0ea20dd1cc4533fd519b5542a89feb87 ocaml(Num) =
cfa2705c9c6d6f5a56b83f91fc630d2a ocaml(Obj) = 5cfae708052c692ea39d23ed930fd64d
ocaml(Outcometree) = 6674fbd870cb2522aca4d851f3559202 ocaml(Parsetree) =
b59a1a6771867acd824bde52e6512b5c ocaml(Path) = d8bc8e7163bac3a9a0a93f1cb07092d1
ocaml(Pervasives) = 8ba3d1faa24d659525c9025f41fd0c57 ocaml(Primitive) =
43a2770aed8fbcc536ab39d717fe9a7b ocaml(Printf) =
5dbbf45a03b54e6dbfcf39178d0d6341 ocaml(Ratio) = 7067125cce206dd2bbe93918ba7bdfe9
ocaml(Set) = 7da14e671a035f12386ace3890018ef3 ocaml(Sort) =
089a51dd8ddc078e57acf2f80b7c06f6 ocaml(Stream) =
21a833e12efd34ea0c87d8d9da959809 ocaml(String) =
2c162ab314b2f0a2cfd22d471b2e21ab ocaml(Sys) = 0da495f5a80f31899139359805318f28
ocaml(Topdirs) = 2d07b01227af22b60aee18498198c35e ocaml(Toploop) =
ead8879d71c4d5137fe5100fdd682a0b ocaml(Types) = c2ef3369acfd38dafc8294786964051c
ocaml(Warnings) = abcb1589615da86f20f475b0ed3bbabc ocaml = 3.10.0-1.fc8

== Rpmlint output: ==

 [ Check ] From rpm:

W: ocaml-findlib devel-file-in-non-devel-package /usr/lib64/ocaml/findlib/findlib.a
W: ocaml-findlib devel-file-in-non-devel-package
/usr/lib64/ocaml/num-top/num_top_printers.cmi
W: ocaml-findlib devel-file-in-non-devel-package
/usr/lib64/ocaml/num-top/num_top.cmi
W: ocaml-findlib devel-file-in-non-devel-package
/usr/lib64/ocaml/findlib/topfind.cmi
W: ocaml-findlib devel-file-in-non-devel-package
/usr/lib64/ocaml/findlib/findlib.cmi
W: ocaml-findlib devel-file-in-non-devel-package
/usr/lib64/ocaml/findlib/fl_package_base.cmi
W: ocaml-findlib devel-file-in-non-devel-package
/usr/lib64/ocaml/findlib/fl_metascanner.cmi
W: ocaml-findlib unstripped-binary-or-object /usr/bin/ocamlfind

  [ Check ] From SRPM :

E: ocaml-findlib configure-without-libdir-spec
W: ocaml-findlib mixed-use-of-spaces-and-tabs (spaces: line 4, tab: line 51)

=== Issues ===

>From RPM file:
According to the OCaml packaging guideloine, these Warning can be ignored.

>From SRPM file:
Currently Upstream's Configure file doesn't provides --libdir option.
On the other hand its provides its own command line to locate and get libraries
directory. And doesn't affect the work of the build.
So, This error can be ignored.

the warning, easy fix ;).

Note that, this review has been done with the fixed SRPM which i proposed in
[comment #22]

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.