[Bug 211761] Review Request: dfu-programmer - USB DFU based programmer for Atmel chips

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: dfu-programmer - USB DFU based programmer for Atmel chips


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=211761





------- Additional Comments From tibbs at math.uh.edu  2007-07-08 21:05 EST -------
I note that the %{?dist} tag is not present.  This is not an absolute
requirement, but I need to make sure you understand how you maintain multiple
branches and the necessary orderings between them without out it.  (And if you
have to ask how you do that, you probably just want to add the dist tag and be
happy.)  See http://fedoraproject.org/wiki/Packaging/DistTag for more info.

You don't need the manual libusb runtime dependency, and in fact it's
misleading.  rpm will find the appropriate library dependency by itself, so
there's no reason to tell it.  The built package won't work with any libusb with
the required version, it will work with only a libusb package that provides the
version of the libusb library that it was built against.  It's best to just let
RPM figure things out, which it does quite well in this case.

Review:
* source files match upstream:
   eef7c56d4915880c1faa67d6b20be727352f5002955a29bbd24020462f733792  
   dfu-programmer-0.4.2.tar.gz
* package meets naming and versioning guidelines.
* specfile is properly named, is cleanly written and uses macros consistently.
* summary is OK.
* description is OK.
X dist tag is present.
* build root is OK.
* license field matches the actual license.
* license is open source-compatible.
* license text included in package.
* latest version is being packaged.
* BuildRequires are proper.
* compiler flags are appropriate.
* %clean is present.
* package builds in mock (development, x86_64).
* package installs properly
* debuginfo package looks complete.
* rpmlint is silent.
X final provides and requires has unneeded libusb dependency.
   dfu-programmer = 0.4.2-1
  =
X  libusb >= 0.1.10a
   libusb-0.1.so.4()(64bit)

* %check is not present; no test suite upstream.  I haven't the hardware needed 
   to test this.
* no shared libraries are added to the regular linker search paths.
* owns the directories it creates.
* doesn't own any directories it shouldn't.
* no duplicates in %files.
* file permissions are appropriate.
* no scriptlets present.
* code, not content.
* documentation is small, so no -docs subpackage is necessary.
* %docs are not necessary for the proper functioning of the package.
* no headers.
* no pkgconfig files.
* no static libraries.
* no libtool .la files.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.