[Bug 246747] Review Request: postgresql-ip4r - IPv4 and IPv4 range index types for PostgreSQL

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: postgresql-ip4r - IPv4 and IPv4 range index types for PostgreSQL


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=246747





------- Additional Comments From devrim at commandprompt.com  2007-07-09 10:10 EST -------
Hello,

(In reply to comment #1)

> ****  - License is BSD, which corresponds to pgfoundry page.  Actual source
> distribution does not contain any Licensing attribution

Yeah, I bugged the developers about this.
 
> ***** - ldconfig is called, however the .so files are not installed in the
> system library search paths, so it appears that this step is redundant.

'k, removed. 

> ***** - The package does not own the directory %{_datadir}/%{name}

Ok, fixed.

> ***** - SHOULD: The description and summary sections in the package spec file
> should contain translations for supported Non-English languages, if available.

There are no translations available.
 
> ***** - SHOULD: Usually, subpackages other than devel should require the base
> package using a fully versioned dependency.

No subpackage, so no need for this item.
 
>   It seems to me that this extension might now work with postgres 8.3, 8.4,
> 9.0??  The following Requires appears overly broad...

It may work, if one day those releases are out. I don't want to limit it to 8.2.

> ***** Consider adding the -p flag to the install commands for the sql and the
> README file to preserve the original timestamps.

Ok, done.

Thanks for the review.

Regards, Devrim

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.