[Bug 246356] Review Request: perl-Gearman-Client-Async - Asynchronous Client for the Gearman distributed job system

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: perl-Gearman-Client-Async - Asynchronous Client for the Gearman distributed job system


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=246356


tibbs at math.uh.edu changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|nobody at fedoraproject.org    |tibbs at math.uh.edu
               Flag|                            |fedora-review+




------- Additional Comments From tibbs at math.uh.edu  2007-07-11 15:24 EST -------
OK, looks good to me.

* source files match upstream:
   8f8fa7722c82a27130224828629b8c680eb99e15e562d17e02d57c3f097826ea  
   Gearman-Client-Async-0.94.tar.gz
* package meets naming and versioning guidelines.
* specfile is properly named, is cleanly written and uses macros consistently.
* summary is OK.
* description is OK.
* dist tag is present.
* build root is OK.
* license field matches the actual license.
* license is open source-compatible.
* license text not included upstream.
* latest version is being packaged.
* BuildRequires are proper.
* compiler flags are appropriate.
* %clean is present.
* package builds in mock (development, x86_64).
* package installs properly
* rpmlint is silent.
* final provides and requires are sane:
   perl(Gearman::Client::Async) = 0.94
   perl(Gearman::Client::Async::Connection)
   perl(Gearman::ResponseParser::Async)
   perl-Gearman-Client-Async = 0.94-3.fc8
  =
   perl(:MODULE_COMPAT_5.8.8)
   perl(Carp)
   perl(Danga::Socket) >= 1.52
   perl(Gearman::Client::Async::Connection)
   perl(Gearman::JobStatus)
   perl(Gearman::Objects)
   perl(Gearman::ResponseParser)
   perl(Gearman::Task)
   perl(Gearman::Util)
   perl(IO::Handle)
   perl(List::Util)
   perl(Scalar::Util)
   perl(Socket)
   perl(base)
   perl(constant)
   perl(fields)
   perl(strict)
   perl(vars)
   perl(warnings)
* %check is present and all tests pass:
   All tests successful.
   Files=11, Tests=32, 26 wallclock secs ( 1.48 cusr +  0.55 csys =  2.03 CPU)
* owns the directories it creates.
* doesn't own any directories it shouldn't.
* no duplicates in %files.
* file permissions are appropriate.
* no scriptlets present.
* code, not content.
* documentation is small, so no -docs subpackage is necessary.
* %docs are not necessary for the proper functioning of the package.

APPROVED

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.