[Bug 247858] Review Request: R-mvtnorm - Multivariate normal and T distrubution R Package

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: R-mvtnorm - Multivariate normal and T distrubution R Package


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=247858


tibbs at math.uh.edu changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+




------- Additional Comments From tibbs at math.uh.edu  2007-07-12 01:01 EST -------
In addition to the expected two rpmlint complaints, I see:
   W: R-mvtnorm incoherent-version-in-changelog 0.7.5-2 0.7-2.fc8
Is the version "0.7" or "0.7.5"?

I'm afraid I don't understand what the test suite is telling me.  One test finds
several differences in the sixth decimal place but the ends with OK.  I'm making
the assumption that it would indicate an actual failure.

Review:
* source files match upstream:
   494048d08b9f11925c207584d55a6bc2c4bf199262e0de421f4f52fc5fb7a1cc  
   mvtnorm_0.7-5.tar.gz
* package meets naming and versioning guidelines.
* specfile is properly named, is cleanly written and uses macros consistently.
   (Follows R template)
* summary is OK.
* description is OK.
* dist tag is present.
* build root is OK.
* license field matches the actual license.
* license is open source-compatible.
* license text not included upstream.
* latest version is being packaged.
* BuildRequires are proper.
* compiler flags are appropriate.
* %clean is present.
* package builds in mock (development, x86_64).
* package installs properly
* debuginfo package looks complete.
X rpmlint has a valid complaint.
* final provides and requires are sane:
   mvtnorm.so()(64bit)
   R-mvtnorm = 0.7-2.fc8
  =
   /bin/sh
   R
   libR.so()(64bit)
   libgcc_s.so.1()(64bit)
   libgfortran.so.1()(64bit)
* %check is present and all tests pass (I think).
* no shared libraries are added to the regular linker search paths.
* owns the directories it creates.
* doesn't own any directories it shouldn't.
* no duplicates in %files.
* file permissions are appropriate.
* scriptlets are OK (R document index generation)
* code, not content.
* documentation is small, so no -docs subpackage is necessary.
* %docs are not necessary for the proper functioning of the package.
* no headers.
* no pkgconfig files.
* no static libraries.
* no libtool .la files.

Really, the changelog thing is trivial to fix, so I'll approve this and you can
fix it when you check in.

APPROVED

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.