[Bug 241279] Review Request: avr-libc - C library for use with GCC on Atmel AVR microcontrollers

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: avr-libc - C library for use with GCC on Atmel AVR microcontrollers


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=241279





------- Additional Comments From mebrown at michaels-house.net  2007-07-13 17:09 EST -------
http://fedoraproject.org/wiki/Packaging/ReviewGuidelines

SHOULD items (no problems here):

- SHOULD: If the source package does not include license text(s) as a separate
file from upstream, the packager SHOULD query upstream to include it.
   --> GOOD

- SHOULD: The description and summary sections in the package spec file should
contain translations for supported Non-English languages, if available.
   --> Ok (no translations)

- SHOULD: The reviewer should test that the package builds in mock.
   --> builds

- SHOULD: The package should compile and build into binary rpms on all supported
architectures.
   --> cant check this myself.

- SHOULD: The reviewer should test that the package functions as described. A
package should not segfault instead of running, for example.
   --> works ok for me.

- SHOULD: If scriptlets are used, those scriptlets must be sane.
   --> no scriptlets

- SHOULD: Usually, subpackages other than devel should require the base package
using a fully versioned dependency.
   --> no subpackages

- SHOULD: The placement of pkgconfig(.pc) files depends on their usecase,
   --> no pc files

- SHOULD: If the package has file dependencies outside of /etc, /bin, /sbin,
/usr/bin,
   --> no additional deps.


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.