[Bug 248277] Review Request: mt-daapd - An iTunes-compatible media server

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: mt-daapd - An iTunes-compatible media server


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=248277


peter at thecodergeek.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |peter at thecodergeek.com




------- Additional Comments From peter at thecodergeek.com  2007-07-14 23:03 EST -------
Not a full review, but there are some things that need fixing in your spec:

(1) Don't use the %makeinstall macro if at all possible. Use '%make
DESTDIR=%{buildroot} install' instead. See
http://fedoraproject.org/wiki/PackagingDrafts/MakeInstall for more information.

(2) Your cp invocations in %install should use the '-P' parameter to preserve
timestamp information.

(3) You are using hardcoded paths instead of macro-based paths: E.g.,
"/usr/sbin" instead of "%{_sbindir}" and the like. See
http://fedoraproject.org/wiki/Packaging/RPMMacros for a full list.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.