[Bug 248301] Review Request: lzma - lzma compression tools

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: lzma - lzma compression tools


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=248301





------- Additional Comments From fedora at marcbradshaw.co.uk  2007-07-15 23:24 EST -------
Hi Patrice,

I am also seeking sponsorship so these are some informal suggestions based on a
first look at the spec rather than an actual review.

Make use of standard macros in Source:
http://tukaani.org/%{name}/%{name}-%{version}beta3.tar.gz

lzma-devel should have lzma as a dependency

The changelog lacks a version

Some RPMLint errors need addressing.

E: lzma-libs library-without-ldconfig-postin /usr/lib/liblzmadec.so.0.0.0
E: lzma-libs library-without-ldconfig-postun /usr/lib/liblzmadec.so.0.0.0
W: lzma-libs non-standard-group System/Libraries
W: lzma-devel non-standard-group Development/C

Man pages should be installed as %doc

-M

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.