[Bug 248393] Review Request: perl-Text-WordDiff - Track changes between documents

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: perl-Text-WordDiff - Track changes between documents


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=248393


panemade at gmail.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+




------- Additional Comments From panemade at gmail.com  2007-07-19 23:43 EST -------
Review:
+ package builds in mock (development i386).
+ rpmlint is silent for SRPM and for RPM.
+ source files match upstream url
e4ad90ec41816be47db9dd1b55af3fbb  Text-WordDiff-0.02.tar.gz
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ %doc is present.
+ BuildRequires are proper.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code, not content.
+ no headers or static libraries.
+ no .pc file present.
+ no -devel subpackage
+ no .la files.
+ no translations are available
+ Does owns the directories it creates.
+ no scriptlets present.
+ no duplicates in %files.
+ file permissions are appropriate.
+ make test outputs
t/ansicolor....ok
t/base.........ok
t/html.........ok
t/pod..........ok
All tests successful.
Files=4, Tests=41,  1 wallclock secs ( 0.40 cusr +  0.07 csys =  0.47 CPU)
+ Provides: perl(Text::WordDiff) = 0.02 perl(Text::WordDiff::ANSIColor) = 0.02
perl(Text::WordDiff::Base) perl(Text::WordDiff::HTML) = 0.02
+ Requires: perl(:MODULE_COMPAT_5.8.8) perl(Algorithm::Diff)
perl(Algorithm::Diff) >= 1.19 perl(Carp) perl(HTML::Entities)
perl(HTML::Entities) perl(IO::File) perl(Term::ANSIColor) perl(constant)
perl(strict) perl(vars)

APPROVED.


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.