[Bug 248403] Review Request: perl-Test-Class - Easily create test classes in an xUnit/JUnit style

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: perl-Test-Class - Easily create test classes in an xUnit/JUnit style


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=248403


panemade at gmail.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+




------- Additional Comments From panemade at gmail.com  2007-07-20 00:13 EST -------
Review:
+ package builds in mock (development i386).
+ rpmlint is silent for SRPM and for RPM.
+ source files match upstream url
dc27881e002abb283b96e083e7eb49c4  Test-Class-0.24.tar.gz
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ %doc is present.
+ BuildRequires are proper.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code, not content.
+ no headers or static libraries.
+ no .pc file present.
+ no -devel subpackage
+ no .la files.
+ no translations are available
+ Does owns the directories it creates.
+ no scriptlets present.
+ no duplicates in %files.
+ file permissions are appropriate.
+ make test outputs
t/00-load..............# Testing Test::Class::Load 0.02, Perl 5.008008,
/usr/bin/perl
ok
t/20-load-classes......ok
t/Tests................ok
t/_new.................ok
t/bad-autoloads........Prototype mismatch: sub CORE::GLOBAL::caller (;$) vs none
at /usr/lib/perl5/vendor_perl/5.8.8/Contextual/Return.pm line 12.
ok
t/bailout..............ok
t/builder..............ok
t/compile..............ok
t/current_method.......ok
t/diag_on_failure......ok
t/die_before_plan......ok
t/expected_tests.......ok
t/fail1................ok
t/fail2................ok
t/fail3................ok
t/header...............ok
t/late_header..........ok
t/methodinfo...........ok
t/named_test...........ok
t/num_method_tests.....ok
t/num_tests............ok
t/override.............ok
t/rt15870..............ok
t/rt17264..............ok
t/run_all_tests........ok
t/runtests.............ok
t/runtests_die.........ok
t/runtests_extra.......ok
t/runtests_noplan......ok
t/runtests_of..........ok
t/runtests_result......ok
t/runtests_return......ok
t/runtests_trailing....ok
t/skip1................ok
t/skip2................ok
t/skip_class_reason....ok
t/spaces...............ok
t/startup..............ok
t/startup_that_dies....ok
t/test_classes.........ok
t/test_deep............ok
t/test_method..........ok
t/test_verbose.........ok
t/todo.................ok
All tests successful.
Files=44, Tests=160,  4 wallclock secs ( 2.93 cusr +  0.60 csys =  3.53 CPU)
+ exit 0
+Provides: perl(Test::Class) = 0.24 perl(Test::Class::Load) = 0.02
perl(Test::Class::MethodInfo) = 0.02
+Requires: perl >= 0:5.006 perl(:MODULE_COMPAT_5.8.8) perl(Attribute::Handlers)
perl(Carp) perl(Class::ISA) perl(Devel::Symdump) perl(Devel::Symdump) >= 2.03
perl(File::Find) perl(File::Spec) perl(Storable) perl(Test::Builder)
perl(Test::Class) perl(Test::Class::MethodInfo) perl(Test::Exception) >= 0.15
perl(constant) perl(strict) perl(warnings)

APPROVED.


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.