[Bug 248899] Review Request: kdelibs3 - K Desktop Environment 3 - Libraries

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: kdelibs3 - K Desktop Environment 3 - Libraries


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=248899





------- Additional Comments From kevin at tigcc.ticalc.org  2007-07-20 15:35 EST -------
Let's start with some fun from rpmlint:

Source RPM:
  > W: kdelibs3 strange-permission kde.sh 0755
  > W: kdelibs3 strange-permission kde.csh 0755
  Bad: While these are not strange for a shell script, these are /etc/profile.d 
scripts which are sourced, so they don't need executable perms (see below).
  > E: kdelibs3 invalid-spec-name kdelibs.spec
  Bad: The specfile needs renaming.
  > W: kdelibs3 mixed-use-of-spaces-and-tabs (spaces: line 25, tab: line 31)
  OK, who cares? ;-)
  > W: kdelibs3 patch-not-applied Patch139445: 
kdelibs-3.5.5-lib_loader-1.2.patch
  > W: kdelibs3 patch-not-applied Patch41: kdelibs-3.5.6-utempter.patch
  > W: kdelibs3 patch-not-applied Patch502: kdelibs-3.5.0-101956.patch
  What about these?

i386 RPM:
  > W: kdelibs3 no-documentation
  Bad: At least the license should be shipped as %doc, possibly also other 
stuff (readme files etc.).
  > W: kdelibs3 devel-file-in-non-devel-package /usr/bin/kde-config
  OK, kde-config is used by some non-devel stuff too AFAIK, so this is normal.
  > E: kdelibs3 executable-marked-as-config-file /etc/profile.d/kde3.csh
  > E: kdelibs3 executable-sourced-script /etc/profile.d/kde3.csh 0755
  > E: kdelibs3 executable-marked-as-config-file /etc/profile.d/kde3.sh
  > E: kdelibs3 executable-sourced-script /etc/profile.d/kde3.sh 0755
  Bad: These should probably not be executable.
  > W: kdelibs3 dangling-relative-symlink /usr/bin/kfmexec kioexec
  OK, kioexec is in kdebase 4, and the symlink is needed for backwards 
compatibility.
  > E: kdelibs3 setuid-binary /usr/bin/kgrantpty root 04755
  > E: kdelibs3 non-standard-executable-perm /usr/bin/kgrantpty 04755
  OK.
  > W: kdelibs3 incoherent-version-in-changelog 6:3.5.7-14 3.5.7-14.fc8
  OK, someone needs to teach rpmlint about epochs and disttags...
  > E: kdelibs3 invalid-soname /usr/lib/libkdeinit_kaddprinterwizard.so 
libkdeinit_kaddprinterwizard.so
  > E: kdelibs3 invalid-soname /usr/lib/libkdeinit_klauncher.so 
libkdeinit_klauncher.so
  > E: kdelibs3 invalid-soname /usr/lib/libkdeinit_kio_http_cache_cleaner.so 
libkdeinit_kio_http_cache_cleaner.so
  > E: kdelibs3 invalid-soname /usr/lib/libkdeinit_kbuildsycoca.so 
libkdeinit_kbuildsycoca.so
  > E: kdelibs3 invalid-soname /usr/lib/libkdeinit_kcmshell.so 
libkdeinit_kcmshell.so
  > E: kdelibs3 invalid-soname /usr/lib/libkdeinit_kio_uiserver.so 
libkdeinit_kio_uiserver.so
  > E: kdelibs3 invalid-soname /usr/lib/libkdeinit_kcookiejar.so 
libkdeinit_kcookiejar.so
  > E: kdelibs3 invalid-soname /usr/lib/libkdeinit_kded.so libkdeinit_kded.so
  > E: kdelibs3 invalid-soname /usr/lib/libkdeinit_kconf_update.so 
libkdeinit_kconf_update.so
  > E: kdelibs3 invalid-soname /usr/lib/libkdeinit_cupsdconf.so 
libkdeinit_cupsdconf.so
  > E: kdelibs3 invalid-soname /usr/lib/libkdeinit_dcopserver.so 
libkdeinit_dcopserver.so
  OK, rpmlint doesn't understand kdeinit either.
  > E: kdelibs3 
file-in-usr-marked-as-conffile /usr/share/config/ui/ui_standards.rc
  OK too.
  > E: kdelibs3 
invalid-desktopfile /tmp/kdelibs3-3.5.7-14.fc8.i386.rpm.16144/usr/share/applications/kde/kresources.desktop
  Not sure about this one.

i386 -devel RPM:
  > W: kdelibs3-devel no-documentation
  OK, the documentation is in -apidocs where it belongs to.
  > W: kdelibs3-devel spurious-executable-perm /usr/lib/libkdefakes_nonpic.a
  Bad: Static libs aren't supposed to be executable, are they?
  > W: kdelibs3-devel summary-ended-with-dot Header files and documentation for 
compiling KDE applications.
  Bad, this is hairsplitting, but the guidelines explicitly say there should be 
no dot here. :-)

i386 -debuginfo RPM: no output

i386 -apidocs RPM: can't check because it hasn't been built yet (I'm looking 
at -14)

x86_64 RPMs: same as the corresponding i386 versions, plus some warnings about 
object file formats due to me running rpmlint on an i386 machine

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.