[Bug 248857] Review Request: schedtool - A tool to query or alter process scheduling policy

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: schedtool - A tool to query or alter process scheduling policy


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=248857


fedora at leemhuis.info changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED




------- Additional Comments From fedora at leemhuis.info  2007-07-22 04:47 EST -------
Blocker:
* Please s!%{_prefix}/bin/!%{_bindir}/! in %files section

Some other notes; please think about them and fix where you agree with them:

* the summary starts with "A " -- the rule of tumb iirc is to go without it
(e.g. Summary: Tool to foo)

* The description starts in lower case; rule of tumb iirc is to start capitalized

* Please tell upstream that

> Copyright (C) 19yy  <name of author>
> Gnomovision version 69, Copyright (C) 19yy name of author

in LICENSE looks bogus ;-)

* is there a specific reasons why you excluded TODO? I'd say it should be
shipped -- it's small and doesn't do any harm for those not intersted in it

* that DESTPREFIX stuff looks intersting, but well, it seems to be needed...

* might be better to not let the Makefile gzip the man page as rpm does this on
its own (in case rpm starts to use bz2 or whatever in the long term) 

Will approve the package and sponser you if you fix the blocker and comment on
the other stuff.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.