[Bug 238238] Review Request: perl-Catalyst-Devel - Catalyst Development Tools

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: perl-Catalyst-Devel - Catalyst Development Tools
Alias: perl-Catalyst-Devel

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=238238


panemade at gmail.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+




------- Additional Comments From panemade at gmail.com  2007-07-25 03:10 EST -------
Review:
+ package builds in mock (development i386).
+ rpmlint is silent for SRPM and for RPM.
+ source files match upstream url
09dd471b600f4dddadc57ee5b56b2d02  Catalyst-Devel-1.02.tar.gz
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ %doc is present.
+ BuildRequires are proper.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code, not content.
+ no headers or static libraries.
+ no .pc file present.
+ no -devel subpackage
+ no .la files.
+ no translations are available
+ Does owns the directories it creates.
+ no scriptlets present.
+ no duplicates in %files.
+ file permissions are appropriate.
+ make test outputs
PERL_DL_NONLAZY=1 /usr/bin/perl "-MExtUtils::Command::MM" "-e" "test_harness(0,
'inc', 'blib/lib', 'blib/arch')" t/*.t
t/01use............ok
t/02pod............ok
t/03podcoverage....ok
All tests successful.
Files=3, Tests=8,  1 wallclock secs ( 0.35 cusr +  0.05 csys =  0.40 CPU)
+ exit 0
+ Provides: perl(Catalyst::Devel) = 1.02 perl(Catalyst::Helper)
perl(Catalyst::Module::Install) perl(Module::Install::Catalyst)
+ Requires: /usr/bin/perl perl(:MODULE_COMPAT_5.8.8) perl(Catalyst) >= 5.7000
perl(Catalyst::Action::RenderView) >= 0.04 perl(Catalyst::Devel)
perl(Catalyst::Exception) perl(Catalyst::Helper) perl(Catalyst::Manual) >=
5.7000 perl(Catalyst::Plugin::ConfigLoader)
perl(Catalyst::Plugin::Static::Simple) >= 0.14 perl(Catalyst::Utils)
perl(Class::Accessor::Fast) perl(Config) perl(File::Copy::Recursive)
perl(File::Find) perl(File::Path) perl(File::Spec) perl(FindBin)
perl(Getopt::Long) perl(IO::File) perl(Module::Install) >= 0.64
perl(Module::Install::Base) perl(POSIX) perl(Path::Class) >= 0.09
perl(Pod::Usage) perl(Template) perl(YAML) >= 0.55 perl(base) perl(strict)
perl(warnings)

APPROVED.



-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.